1310440 - Accesskey conflict in Views tab for Calendar options

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Decathlon]

In Tool > Options > Calendar > Views there are two checkboxes with the same accesskey "w": "Show week number in views and minimonth" and the workweek "Wed".

Both the checkboxes are selectable with Alt+w but the selection switches between them every time the Alt+w is pressed and it requires to press the space key to tick/de-tick the checkbox.

Comment 1

[Decathlon]

Attachment: patch-v1

Few free letters. Take the "n".

Comment 2

[[:MakeMyDay]]

Comment on attachment 8801535 [details] [diff] [review]
patch-v1

Review of attachment 8801535 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 3

[:aceman]

https://hg.mozilla.org/comm-central/rev/eac55676afb38b13698b3d9cfc0ecf2ff05ea1ea

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8801535 [details] [diff] [review]
patch-v1

I've just changed my queries to find bugs that need uplift and found this one here.
This landed on 5.4/52 and got uplift approval to Aurora 5.3/51 and Beta 5.2/50 at the time.
It never got uplifted. Since we're now at 5.5/53 I can at best uplift this to 5.3/51, current beta. Here is the Aurora landing which I need for my query to work:
https://hg.mozilla.org/releases/comm-aurora/rev/eac55676afb3

Comment 5

[[:MakeMyDay]]

I would suggest to let this ride the regular train since this is in 5.4 already. Decathlon, do you have any objections?

Comment 6

[Decathlon]

No objection.
The option works anyway with the keyboard without the patch.

Comment 7

[Jorg K (CEST = GMT+2)]

You should clear the approvals than, since my query picks it up as needing landing unless I paste a fake beta changeset there ;-)

releases/comm-beta/rev/not-landed

Comment 8

[Decathlon]

(In reply to Jorg K (GMT+1) from comment #7)
> You should clear the approvals than, since my query picks it up as needing
> landing unless I paste a fake beta changeset there ;-)
> 
> releases/comm-beta/rev/not-landed

Philipp, it needs someone with the "power" here ;)