Closed Bug 1310440 Opened 5 years ago Closed 5 years ago

Accesskey conflict in Views tab for Calendar options

Categories

(Calendar :: General, defect)

Lightning 4.5
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bv1578, Assigned: bv1578)

Details

Attachments

(1 file)

In Tool > Options > Calendar > Views there are two checkboxes with the same accesskey "w": "Show week number in views and minimonth" and the workweek "Wed".

Both the checkboxes are selectable with Alt+w but the selection switches between them every time the Alt+w is pressed and it requires to press the space key to tick/de-tick the checkbox.
Attached patch patch-v1Splinter Review
Few free letters. Take the "n".
Attachment #8801535 - Flags: review?(makemyday)
Attachment #8801535 - Flags: approval-calendar-beta?(philipp)
Attachment #8801535 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8801535 [details] [diff] [review]
patch-v1

Review of attachment 8801535 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8801535 - Flags: review?(makemyday) → review+
Attachment #8801535 - Flags: approval-calendar-beta?(philipp)
Attachment #8801535 - Flags: approval-calendar-beta+
Attachment #8801535 - Flags: approval-calendar-aurora?(philipp)
Attachment #8801535 - Flags: approval-calendar-aurora+
https://hg.mozilla.org/comm-central/rev/eac55676afb38b13698b3d9cfc0ecf2ff05ea1ea
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [aurora,beta]
Target Milestone: --- → 5.4
Comment on attachment 8801535 [details] [diff] [review]
patch-v1

I've just changed my queries to find bugs that need uplift and found this one here.
This landed on 5.4/52 and got uplift approval to Aurora 5.3/51 and Beta 5.2/50 at the time.
It never got uplifted. Since we're now at 5.5/53 I can at best uplift this to 5.3/51, current beta. Here is the Aurora landing which I need for my query to work:
https://hg.mozilla.org/releases/comm-aurora/rev/eac55676afb3
I would suggest to let this ride the regular train since this is in 5.4 already. Decathlon, do you have any objections?
Flags: needinfo?(bv1578)
No objection.
The option works anyway with the keyboard without the patch.
Flags: needinfo?(bv1578)
Keywords: checkin-needed
Whiteboard: [aurora,beta]
You should clear the approvals than, since my query picks it up as needing landing unless I paste a fake beta changeset there ;-)

releases/comm-beta/rev/not-landed
(In reply to Jorg K (GMT+1) from comment #7)
> You should clear the approvals than, since my query picks it up as needing
> landing unless I paste a fake beta changeset there ;-)
> 
> releases/comm-beta/rev/not-landed

Philipp, it needs someone with the "power" here ;)
Flags: needinfo?(philipp)
Flags: needinfo?(philipp)
Attachment #8801535 - Flags: approval-calendar-beta+
Attachment #8801535 - Flags: approval-calendar-aurora+
You need to log in before you can comment on or make changes to this bug.