1310443 - Fix Direct2D detection in reftests when using the GPU process

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

When using the GPU process, Direct2D is disabled in the UI but enabled in content. This appears to lead to reftest fails because the repeat sampling/d2d checks are confused: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=29210838

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Since TreeHerder does not use the Platform Update on its Windows 7 machines, we fail to create a swap chain in the D3D11 compositor. This is expected since remote presentation was not supported until DXGI 1.2. However it's creating a mismatch between the device state (ok) and compositor state (which will always fail to initialize). That's why the reftest harness thinks we should be using Direct2D.

Ultimately we want to exit the GPU process on this condition, or even avoid launching it in the first place. Let's save that for bug 1297822.

For now this patch just adds a check to DeviceManagerDx, so we won't try to create D3D11 compositors when they're doomed to fail.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Comment on attachment 8804112 [details] [diff] [review]
fix

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b943d19facc6
Don't create remote D3D11 devices when remote presentation is broken. (bug 1310443, r=rhunt)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b943d19facc6