1310603 - Add 'source' icon (Bookmarked/Visited) to Activity Stream highlights

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1310603 - Activity Stream highlights: Add "Visited" and "Bookmarked" icons.

Review commit: https://reviewboard.mozilla.org/r/86314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86314/

Comment 2

[:Grisha Kruglov]

Comment on attachment 8801645 [details]
Bug 1310603 - Activity Stream highlights: Add "Visited" and "Bookmarked" icons.

https://reviewboard.mozilla.org/r/86314/#review85230

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamItem.java:143
(Diff revision 1)
>                  vSourceView.setText(R.string.activity_stream_highlight_label_visited);
>                  vSourceView.setVisibility(View.VISIBLE);
> +                vSourceIconView.setImageResource(R.drawable.ic_as_visited);
>              } else {
>                  vSourceView.setVisibility(View.INVISIBLE);
> +                vSourceIconView.setImageResource(0);

I take it this works, but it looks weird to me. What whill this call actually do? Can it throw?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8801645 [details]
Bug 1310603 - Activity Stream highlights: Add "Visited" and "Bookmarked" icons.

https://reviewboard.mozilla.org/r/86314/#review85468

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamItem.java:143
(Diff revision 1)
>                  vSourceView.setText(R.string.activity_stream_highlight_label_visited);
>                  vSourceView.setVisibility(View.VISIBLE);
> +                vSourceIconView.setImageResource(R.drawable.ic_as_visited);
>              } else {
>                  vSourceView.setVisibility(View.INVISIBLE);
> +                vSourceIconView.setImageResource(0);

This will reset the image in case there's one assigned from a previous call to bind().

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b2ff5b21e39
Activity Stream highlights: Add "Visited" and "Bookmarked" icons. r=Grisha

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8b2ff5b21e39

Comment 6

[Carmen Fat [:cfat] - Ecosystem QA]

The fix is now verified on latest Nightly (2016-11-10), using the next devices:
- Nexus 5 (Android 6.0.1);
- Huawei Honor 5x (Android 5.1.1).