Closed Bug 1310712 Opened 8 years ago Closed 8 years ago

Search URL differs after the list.txt was replaced with the list.json on Canada

Categories

(Firefox :: Search, defect)

52 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 52
Tracking Status
firefox52 --- verified

People

(Reporter: sbadau, Unassigned)

References

Details

Attachments

(1 file)

[Affected versions]:
- Nightly 520.a1

[Affected platforms]:
- Windows XP, Windows 10 and Ubuntu 16.04

[Preconditions]:
-if not in Canada, set a Canadian proxy (I used the Address: 198.50.169.21, Port 3128)

[Steps to reproduce]:
1. Install an older en-US locale build from:
http://archive.mozilla.org/pub/firefox/nightly/2016/09/2016-09-30-03-03-15-mozilla-central/

2. Start Firefox with a new profile and verify in about:config that the preference "browser.search.region" shows “CA”

3. Using the address bar, search for "firefox".

4. Update to latest Nightly and perform the same search.

6. Observe the URL


[Expected result]:
- The search URLs in steps 3 and 6 should be the same as: 
https://www.google.com/search?q=firefox&ie=utf-8&oe=utf-8

[Actual result]:
- An additional search code is added to the URL from step 6 - “client=firefox-b-ab”
https://www.google.com/search?q=firefox&ie=utf-8&oe=utf-8&client=firefox-b-ab

[Regression range]:
- I'll investigate more and post the results as soon as possible.
Attached patch FixSplinter Review
Canada should have the same list as US.

List I had was test only.
Attachment #8801768 - Flags: review?(mconnor)
Comment on attachment 8801768 [details] [diff] [review]
Fix

r+ via email with google moved to the first position.
Attachment #8801768 - Flags: review?(mconnor) → review+
https://hg.mozilla.org/mozilla-central/rev/3014b98afe6d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
The fix is verified on latest Nightly (Build ID 20161101030207). It was tested on the following OS-es:
*Windows 10 x64
*Ubuntu 16.04
*Mac 10.10

When searching with Google, the URL is the same as the one before update (with no additional google codes).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: