Closed
Bug 1310728
Opened 8 years ago
Closed 8 years ago
editflagtypes.cgi crashes when classifications are enabled and the user hasn't global editcomponents privs
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: abarbi, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
477 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459
Steps to reproduce:
0. Login onto Bugzilla.
1. Click on Administration.
2. Click on Flags.
Actual results:
A page saying:
"Software error: Can't use an undefined value as as ARRAY reference at
<snip>/Apache2/htdocs/bugs/editflagtypes.cgi line 456."
is shown. No options to move ahead, obviously.
(note: this is what is seen by some non-admin level, product managers users.
The actual admin doesn't notice any error)
Expected results:
The usual Flags Types admin page should have loaded.
Assignee | ||
Comment 1•8 years ago
|
||
Regression caused by bug 1191706, affecting Bugzilla 5.0 and newer. This error happens when the user hasn't global editcomponents privs and hasn't access to all classifications.
Status: UNCONFIRMED → NEW
Depends on: 1191706
Ever confirmed: true
Keywords: regression
OS: Windows 7 → All
Hardware: x86 → All
Summary: Error shown when entering the Administer Flag Types page → editflagtypes.cgi crashes when classifications are enabled and the user hasn't global editcomponents privs
Target Milestone: --- → Bugzilla 5.0
Updated•8 years ago
|
Assignee: administration → dylan
Assignee | ||
Comment 2•8 years ago
|
||
I caused the regression, so here is the fix.
Comment 3•8 years ago
|
||
Comment on attachment 8801815 [details] [diff] [review]
patch, v1
Review of attachment 8801815 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8801815 -
Flags: review?(dkl) → review+
Updated•8 years ago
|
Flags: approval5.0+
Comment 4•8 years ago
|
||
To https://github.com/bugzilla/bugzilla.git
0fcb110..7d445a4 master -> master
To https://github.com/bugzilla/bugzilla.git
89cb60f..ec6dada 5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•