Closed Bug 1310804 Opened 3 years ago Closed 3 years ago

Limit Mac remote printing to Nightly

Categories

(Core :: Security: Process Sandboxing, defect)

51 Branch
Unspecified
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 - fixed
firefox52 --- fixed

People

(Reporter: haik, Assigned: haik)

References

Details

Attachments

(1 file)

Until bug 1310165 is fixed (which is a problem with Mac remote printing), Mac remote printing should be prevented from riding the trains. This bug fix is to limit Mac remote printing to Nightly. Mac remote printing is enabled in 51 now.

And, since the Mac level 1 content sandbox depends on remote printing, it should also be limited to Nightly. At present, it is only enabled on Nightly, but set to become enabled in 52.
Assignee: nobody → haftandilian
We don't need code changes to limit sandbox level=1 to Nightly because MOZ_CONTENT_SANDOX is already limited to Nightly for Mac builds.
Summary: Limit Mac remote printing and content sandbox level 1 to Nightly → Limit Mac remote printing to Nightly
Comment on attachment 8801887 [details]
Bug 1310804 - Limit Mac remote printing to Nightly;

https://reviewboard.mozilla.org/r/86484/#review85454

r+ with the check fixed.

::: modules/libpref/init/all.js:1123
(Diff revision 1)
>  
>  // Print via the parent process. This is only used when e10s is enabled.
> -#if defined(XP_WIN) || defined(XP_MACOSX)
> +// For Mac, limit to Nightly.
> +#if defined(XP_WIN)
> +pref("print.print_via_parent", true);
> +#elif defined(XP_MACOSX) && defined(NIGHTLY)

This should be NIGHTLY_BUILD.
Attachment #8801887 - Flags: review?(bobowencode) → review+
Keywords: checkin-needed
Please mark the pending issues in MozReview as resolved so that autoland can push it.
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Please mark the pending issues in MozReview as resolved so that autoland can
> push it.

Done.
Flags: needinfo?(ryanvm)
You can just re-set the flag in the future :)
Flags: needinfo?(ryanvm)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/738663e0c33d
Limit Mac remote printing to Nightly; r=bobowen
https://hg.mozilla.org/mozilla-central/rev/738663e0c33d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
[Tracking Requested - why for this release]:
This is a workaround for a printing-to-PDF and PDF.js rendering issue in build 51--bug 1310165.
See Also: → 1310165
Comment on attachment 8801887 [details]
Bug 1310804 - Limit Mac remote printing to Nightly;

Approval Request Comment
[Feature/regressing bug #]:
Exposed by fix for 1228022.

[User impact if declined]:
On Mac, some PDF text will continue to be rasterized when it shouldn't be.

[Describe test coverage new/current, TreeHerder]:
Manually tested on Aurora build. No treeherder test coverage.

[Risks and why]:
Mac remote printing is not ready to ride the trains. We need this fix to disable it for all but Nightly builds.

[String/UUID change made/needed]:
None
Attachment #8801887 - Flags: approval-mozilla-aurora?
Comment on attachment 8801887 [details]
Bug 1310804 - Limit Mac remote printing to Nightly;

Disable mac remote printing in aurora. Take it in 51 aurora.
Attachment #8801887 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
See Also: → 1324908
You need to log in before you can comment on or make changes to this bug.