131081 - nsComponentManagerImpl::ContractIDToCID is broken

Status: VERIFIED DUPLICATE of bug 135966

(Core :: XPCOM, defect)

Description

[Mark Follett]

Hi,

The current (Mozilla 0.9.9) implementation of ContractIDToCID is broken:

(from nsComponentManager.cpp)
NS_IMETHODIMP
nsComponentManagerImpl::ContractIDToCID(const char *aContractID,
                                        nsCID * *_retval)
{
    nsCID aCID;
    nsresult rv = ContractIDToClassID(aContractID, &aCID);
    if (NS_FAILED(rv))
        return rv;

    // not sure about this... FIX
    *_retval = (nsCID*) nsMemory::Alloc(sizeof(nsCID));
    *_retval = &aCID;

    return NS_OK;
}

This sets retval to point to the stack,  which vanishes when the function 
returns.
"*_retval = &aCID" should be replaced with "**_retval = aCID" in order to fill 
the returned CID properly.

Mark Follett

Comment 1

[Boris Zbarsky [:bzbarsky]]

Duplicate of "nsComponentManagerImpl::ContractIDToCID very broken" (fixed on trunk)

*** This bug has been marked as a duplicate of 135966 ***

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, I did search for a bug before I filed a new one, why didn't I find this one?