If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make ScrollFrameHelper::GetScrolledRect skip the hard work in the simple case

RESOLVED FIXED in Firefox 52

Status

()

Core
Layout
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

(Blocks: 2 bugs, {perf})

Trunk
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Before this patch, GetScrolledRect is 12% of bug 1306052, after this patch, it's about 1%.
I'm hoping that this will also help with bug 1293031.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

11 months ago
mozreview-review
Comment on attachment 8801969 [details]
Bug 1310900 - Speed up ScrollFrameHelper::GetScrolledRect for the case where there is no overflow.

https://reviewboard.mozilla.org/r/86542/#review85586
Attachment #8801969 - Flags: review?(matt.woodrow) → review+

Comment 4

11 months ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/0f64a7feb4eb
Speed up ScrollFrameHelper::GetScrolledRect for the case where there is no overflow. r=mattwoodrow

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f64a7feb4eb
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.