1310939 - pass a CARGOFLAGS through to cargo invocations

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Cameron McCormack (:heycam)]

I'd like to see color in cargo's output while building.  It looks like |--color always| makes this work me, but it's probably inappropriate to include in config/rules.mk directly.  cargo doesn't understand a CARGOFLAGS variable, but we could pass one through to the cargo command line.  Then I can set it in my .mozconfig, like I do with CXXFLAGS="-fcolor-diagnostics" for clang.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1310939 - Pass $(CARGOFLAGS) to cargo invocations so cargo flags can be passed from a .mozconfig file.

Review commit: https://reviewboard.mozilla.org/r/86588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86588/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8802017 [details]
Bug 1310939 - Pass $(CARGOFLAGS) to cargo invocations so cargo flags can be passed from a .mozconfig file.

https://reviewboard.mozilla.org/r/86588/#review85530

r=me

::: config/rules.mk:903
(Diff revision 1)
>  endif
>  
>  ifdef MOZ_RUST
>  ifdef RUST_LIBRARY_FILE
>  
> -ifdef MOZ_DEBUG
> +cargo_build_flags = $(CARGOFLAGS)

Can you add a small comment here, like:

Permit users to pass flags to cargo from their mozconfigs (e.g. --color=always).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48001c1d5dc4
Pass $(CARGOFLAGS) to cargo invocations so cargo flags can be passed from a .mozconfig file. r=froydnj

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/48001c1d5dc4