Closed Bug 1310939 Opened 3 years ago Closed 3 years ago

pass a CARGOFLAGS through to cargo invocations

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

I'd like to see color in cargo's output while building.  It looks like |--color always| makes this work me, but it's probably inappropriate to include in config/rules.mk directly.  cargo doesn't understand a CARGOFLAGS variable, but we could pass one through to the cargo command line.  Then I can set it in my .mozconfig, like I do with CXXFLAGS="-fcolor-diagnostics" for clang.
Comment on attachment 8802017 [details]
Bug 1310939 - Pass $(CARGOFLAGS) to cargo invocations so cargo flags can be passed from a .mozconfig file.

https://reviewboard.mozilla.org/r/86588/#review85530

r=me

::: config/rules.mk:903
(Diff revision 1)
>  endif
>  
>  ifdef MOZ_RUST
>  ifdef RUST_LIBRARY_FILE
>  
> -ifdef MOZ_DEBUG
> +cargo_build_flags = $(CARGOFLAGS)

Can you add a small comment here, like:

Permit users to pass flags to cargo from their mozconfigs (e.g. --color=always).
Attachment #8802017 - Flags: review?(nfroyd) → review+
Assignee: nobody → cam
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48001c1d5dc4
Pass $(CARGOFLAGS) to cargo invocations so cargo flags can be passed from a .mozconfig file. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/48001c1d5dc4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
See Also: → 1311567
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.