The default bug view has changed. See this FAQ.

Image preview tooltip remains visible when window loses focus

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Developer Tools: Inspector
VERIFIED FIXED
5 months ago
3 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

Trunk
Firefox 52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

5 months ago
Created attachment 8802041 [details]
image-preview-on-other-window.gif

Regression from Bug 1301342.

Now that the XUL panel used by the HTMLTooltips has the "noautohide" attribute set to true, the tooltips are no longer hidden when the window loses focus (see attached GIF)

This is only an issue for tooltips using a XULPanelWrapper because the other tooltips are constrained to the devtools document and can't be displayed outside of the devtools' window. 

We should try an alternative solution for 1301342 and reuse the fact that XUL panels get automatically hidden rather than preventing it. For instance we could listen for the "hidden" event of the panel, and programmatically hide the corresponding HTMLTooltip when we receive it.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

5 months ago
Implemented the approach described in the summary. Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d98e767c662805160a39652ccfca2096cd6f3d57
(Assignee)

Updated

5 months ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Comment 5

5 months ago
Try is green except for unrelated taskcluster issues. Asking for review!
Comment hidden (mozreview-request)

Comment 7

5 months ago
mozreview-review
Comment on attachment 8802326 [details]
Bug 1310957 - listen to XUL Panel wrapper hidden event to hide HTML tooltip;

https://reviewboard.mozilla.org/r/86742/#review85966
Attachment #8802326 - Flags: review?(gl) → review+

Comment 8

5 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ee4fd380512
listen to XUL Panel wrapper hidden event to hide HTML tooltip;r=gl

Comment 9

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ee4fd380512
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
I have reproduced this bug with Nightly 52.0a1 (2016-10-18) (64-bit) on Windows 7, 64 Bit !

This bug's fix is verified with latest Nightly 

Build ID     20161028030204
User Agent   Mozilla/5.0(Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Thanks for verifying using Windows :mMARUF!

Also confirmed verified fixed under Mac OS X 10.11 with latest Nightly 52.0a1, so I'm updating it's resolution.
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified

Updated

3 months ago
Depends on: 1327979
You need to log in before you can comment on or make changes to this bug.