Closed Bug 1310957 Opened 3 years ago Closed 3 years ago

Image preview tooltip remains visible when window loses focus

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(firefox52 verified)

VERIFIED FIXED
Firefox 52
Tracking Status
firefox52 --- verified

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(2 files)

Regression from Bug 1301342.

Now that the XUL panel used by the HTMLTooltips has the "noautohide" attribute set to true, the tooltips are no longer hidden when the window loses focus (see attached GIF)

This is only an issue for tooltips using a XULPanelWrapper because the other tooltips are constrained to the devtools document and can't be displayed outside of the devtools' window. 

We should try an alternative solution for 1301342 and reuse the fact that XUL panels get automatically hidden rather than preventing it. For instance we could listen for the "hidden" event of the panel, and programmatically hide the corresponding HTMLTooltip when we receive it.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Try is green except for unrelated taskcluster issues. Asking for review!
Comment on attachment 8802326 [details]
Bug 1310957 - listen to XUL Panel wrapper hidden event to hide HTML tooltip;

https://reviewboard.mozilla.org/r/86742/#review85966
Attachment #8802326 - Flags: review?(gl) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ee4fd380512
listen to XUL Panel wrapper hidden event to hide HTML tooltip;r=gl
https://hg.mozilla.org/mozilla-central/rev/9ee4fd380512
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
I have reproduced this bug with Nightly 52.0a1 (2016-10-18) (64-bit) on Windows 7, 64 Bit !

This bug's fix is verified with latest Nightly 

Build ID     20161028030204
User Agent   Mozilla/5.0(Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Thanks for verifying using Windows :mMARUF!

Also confirmed verified fixed under Mac OS X 10.11 with latest Nightly 52.0a1, so I'm updating it's resolution.
Status: RESOLVED → VERIFIED
Depends on: 1327979
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.