1311049 - Rename unifiedcomplete tests to follow the same naming convention

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P5)

Description

[Matthew Wein [:mattw]]

It looks like the predominant naming convention used is lowercase_with_underscores.

Therefore, the following tests should be renamed:
 - test_queryurl.js (should be test_query_url.js)
 - test_remotetabmatches.js (should be test_remote_tab_matches.js)
 - test_searchSuggestions.js (should be test_search_suggestions.js)
 - test_tabmatches.js (should be test_tab_matches.js)
 - test_visiturl.js (should be test_visit_url.js)
 - test_searchSuggestions.js (should be test_search_suggestions.js)
 - test_searchEngine_alias.js (should probably be test_search_engine_alias.js)
 - test_searchEngine_current.js (should probably be test_search_engine_current.js)
 - test_searchEngine_host.js (should probably be test_search_engine_host.js)
 - test_searchEngine_restyle.js (should probably be test_search_engine_restyle.js)
 - test_autoFill_default_behavior.js (should probably be test_autofill_default_behavior.js)

Comment 1

[Marco Bonardo [:mak]]

while I'm not against doing this, why should we spend time on it? is this a bug you would like to mentor?

Comment 2

[Drew Willcoxon :adw]

Matthew filed this bug after I asked him to add an underscore to the name of his new test or make it camel case, to make it easier to read, in bug 1267810.  I forgot that we had other tests like "tabmatches" and "remotetabmatches", and he had named his test in a similar fashion.

I agree it's a "I'm not against it but it's not important" kind of thing.

Comment 3

[Marco Bonardo [:mak]]

oh well. let's just mentor this.

Comment 4

[Matthew Wein [:mattw]]

Attachment: Bug 1311049 - Rename unifiedcomplete tests to follow the same naming convention

Review commit: https://reviewboard.mozilla.org/r/86690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86690/

Comment 5

[Matthew Wein [:mattw]]

I needed a break so I went ahead and made the updates - it took about 5 minutes and I think it's nice to have the consistency.

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8802225 [details]
Bug 1311049 - Rename unifiedcomplete tests to follow the same naming convention

https://reviewboard.mozilla.org/r/86690/#review85824

thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e35c6a772ec4
Rename unifiedcomplete tests to follow the same naming convention r=mak

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e35c6a772ec4