Closed
Bug 1311144
Opened 9 years ago
Closed 8 years ago
Generate a score for a highlights initially using the site's available metadata
Categories
(Firefox for iOS :: Home screen, defect, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.22
Tracking | Status | |
---|---|---|
fxios | 8.0+ | --- |
People
(Reporter: sleroux, Assigned: justindarc)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file, 1 obsolete file)
For the first pass at implementing a scoring algorithm for how we pick which highlights and in which order we want to show, we want to see if a potential highlight has:
1. Associated metadata available
2. A rich preview image as part of that metadata
The idea is that we want to surface sites that are more visual appealing on our highlights list.
Reporter | ||
Updated•9 years ago
|
Whiteboard: [MobileAS]
Reporter | ||
Updated•9 years ago
|
Priority: -- → P2
Comment 1•8 years ago
|
||
I remember hearing that this wont be required for v1? Or are we still doing this.
Are there any improvements we have to make to the highlight algorithm besides this?
Flags: needinfo?(sleroux)
Reporter | ||
Comment 2•8 years ago
|
||
IIRC Sebastian has been working on a scoring implementation on Android for the past while and Desktop has been iterating over what the implementation looks like. In previous discussions it seemed that in terms of priorities getting rich metadata (images) is higher on the list than getting the scoring algorithm in but with Emily working on that I guess that frees us up to look towards implementing some kind of scoring. There are some items I could see us doing before we get scoring involved such as a mechanism to run A/B tests (probably using Switchboard which Android uses).
TBH I could see us shipping a version to our production users that doesn't include any scoring just to collect some data first.
Re-assigning the NI to :barbara for her thoughts.
Flags: needinfo?(sleroux) → needinfo?(bbermes)
Comment 3•8 years ago
|
||
I confirm/agree.
1) Include minimal scoring (as per Steph's suggestion) for MVP
2) Ideally, we have an A/B mechanism in place, and then can validate/iterate on the scoring.
3) Ship and collect information
Flags: needinfo?(bbermes)
Updated•8 years ago
|
Priority: P2 → P3
Comment 4•8 years ago
|
||
We could probably do some minimal ranking of highlights for the MVP.
Priority: P3 → P2
Updated•8 years ago
|
Iteration: --- → 1.20
Priority: P2 → P1
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: 1.20 → 1.21
Updated•8 years ago
|
tracking-fxios:
--- → 8.0+
Assignee | ||
Comment 5•8 years ago
|
||
Farhan, I'm not 100% sure I'm on the right track here, so let me know if you think the "score" should be weighted differently. This patch prioritizes having an icon above all else followed by visitCount. Additional points are given for being bookmarked, having a title, a description and a media_url.
Attachment #8866059 -
Flags: review?(fpatel)
Updated•8 years ago
|
Attachment #8866059 -
Flags: review?(fpatel)
Updated•8 years ago
|
Iteration: 1.21 → 1.22
Assignee | ||
Comment 6•8 years ago
|
||
Farhan, here's a new PR that adds scoring in `computeHighlightsQuery()` instead.
Attachment #8866059 -
Attachment is obsolete: true
Attachment #8870146 -
Flags: review?(fpatel)
Updated•8 years ago
|
Attachment #8870146 -
Flags: review?(fpatel) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Landed on master:
https://github.com/mozilla-mobile/firefox-ios/commit/0c6ca4a4705f15a095e6b5ad414bcf4302f01d43
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [MobileAS] → [MobileAS][needsuplift]
Reporter | ||
Updated•8 years ago
|
Whiteboard: [MobileAS][needsuplift] → [MobileAS]
You need to log in
before you can comment on or make changes to this bug.
Description
•