Closed Bug 1311149 Opened 4 years ago Closed 4 years ago

Remove the b2g preallocated app support

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attachment #8802377 - Flags: review?(amarchesini)
Attachment #8802377 - Flags: review?(amarchesini) → review+
Bug 1310845 needs to be landed first here.  I need to look at this when I get back...
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1ff6d4dca5f
Remove the b2g preallocated app support; r=baku
backed out for merge conflicts during m-i to m-c merge like:

warning: conflicts while merging dom/ipc/ContentBridgeChild.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentBridgeChild.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentChild.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentChild.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentParent.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentParent.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/TabChild.cpp! (edit, then use 'hg resolve --mark')
Flags: needinfo?(ehsan)
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69d33fe8ac7a
Remove the b2g preallocated app support; r=baku
https://hg.mozilla.org/mozilla-central/rev/69d33fe8ac7a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
I think it would have been nice to talk to the e10s team working on multiple content processes before removing this.
Ehsan, is there a reason this is inappropriate to use in desktop in our multiple-content e10s configuration?
Flags: needinfo?(ehsan)
This was pretty b2g specific in at least a few ways: the preload slow things mechanism, the shady zombie presshell stuff, the allocation strategy, etc.  I suppose a little bit of this code can be restored from history if we ever want to do this on desktop, but I suspect the implementation would end up fairly different.

(Note that the reusuble part of this implementation for desktop is essentially just creating a ContentParent on the side, I doubt the removed code is actually very useful.)
Flags: needinfo?(ehsan)
No longer blocks: 1369194
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.