Remove the b2g preallocated app support

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Created attachment 8802377 [details] [diff] [review]
Remove the b2g preallocated app support; r=baku
(Assignee)

Updated

a year ago
Attachment #8802377 - Flags: review?(amarchesini)
Attachment #8802377 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 2

a year ago
Bug 1310845 needs to be landed first here.  I need to look at this when I get back...
Flags: needinfo?(ehsan)
(Assignee)

Comment 3

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=646102071316bfccaf22cd37a0c878f5bda5ce66
Flags: needinfo?(ehsan)

Comment 4

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1ff6d4dca5f
Remove the b2g preallocated app support; r=baku
backed out for merge conflicts during m-i to m-c merge like:

warning: conflicts while merging dom/ipc/ContentBridgeChild.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentBridgeChild.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentChild.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentChild.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentParent.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentParent.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/TabChild.cpp! (edit, then use 'hg resolve --mark')
Flags: needinfo?(ehsan)

Comment 6

a year ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4607c6d4de
Backed out changeset f1ff6d4dca5f
(Assignee)

Updated

a year ago
Flags: needinfo?(ehsan)

Comment 7

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69d33fe8ac7a
Remove the b2g preallocated app support; r=baku

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/69d33fe8ac7a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
I think it would have been nice to talk to the e10s team working on multiple content processes before removing this.
Ehsan, is there a reason this is inappropriate to use in desktop in our multiple-content e10s configuration?
Flags: needinfo?(ehsan)
(Assignee)

Comment 11

a year ago
This was pretty b2g specific in at least a few ways: the preload slow things mechanism, the shady zombie presshell stuff, the allocation strategy, etc.  I suppose a little bit of this code can be restored from history if we ever want to do this on desktop, but I suspect the implementation would end up fairly different.

(Note that the reusuble part of this implementation for desktop is essentially just creating a ContentParent on the side, I doubt the removed code is actually very useful.)
Flags: needinfo?(ehsan)
Blocks: 1369194
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.