1311149 - Remove the b2g preallocated app support

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Remove the b2g preallocated app support; r=baku

Comment 2

[(no longer active)]

Bug 1310845 needs to be landed first here.  I need to look at this when I get back...

Comment 3

[(no longer active)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=646102071316bfccaf22cd37a0c878f5bda5ce66

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1ff6d4dca5f
Remove the b2g preallocated app support; r=baku

Comment 5

[Carsten Book [:Tomcat]]

backed out for merge conflicts during m-i to m-c merge like:

warning: conflicts while merging dom/ipc/ContentBridgeChild.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentBridgeChild.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentChild.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentChild.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentParent.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/ContentParent.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging dom/ipc/TabChild.cpp! (edit, then use 'hg resolve --mark')

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4607c6d4de
Backed out changeset f1ff6d4dca5f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69d33fe8ac7a
Remove the b2g preallocated app support; r=baku

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69d33fe8ac7a

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

I think it would have been nice to talk to the e10s team working on multiple content processes before removing this.

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

Ehsan, is there a reason this is inappropriate to use in desktop in our multiple-content e10s configuration?

Comment 11

[(no longer active)]

This was pretty b2g specific in at least a few ways: the preload slow things mechanism, the shady zombie presshell stuff, the allocation strategy, etc.  I suppose a little bit of this code can be restored from history if we ever want to do this on desktop, but I suspect the implementation would end up fairly different.

(Note that the reusuble part of this implementation for desktop is essentially just creating a ContentParent on the side, I doubt the removed code is actually very useful.)