1311197 - Remove more CPOWs from tests

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I wrote a script to extract CPOW uses in test files[1]. I fixed a bunch of them and will try to get some help for the rest as well as fixing more when I have time.

[1] https://docs.google.com/document/d/1EUUi3tMuhHsJA9iE9yNvjWcae4Unmqrl4uN2VwYxIqE/edit

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1311197 - Remove CPOWs from browser_bug611242.js.

Review commit: https://reviewboard.mozilla.org/r/86726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86726/

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1311197 - Remove CPOWs from browser_localfile2.js.

Review commit: https://reviewboard.mozilla.org/r/86728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86728/

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1311197 - Remove CPOWs from browser_bug655270.js.

Review commit: https://reviewboard.mozilla.org/r/86730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86730/

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1311197 - Remove CPOWs from some plugin mochitests.

Review commit: https://reviewboard.mozilla.org/r/86732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86732/

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1311197 - Remove CPOWs from urlbar tests.

Review commit: https://reviewboard.mozilla.org/r/86734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86734/

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1311197 - Remove CPOWs from docshell browser-chrome tests.

Review commit: https://reviewboard.mozilla.org/r/86736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86736/

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1311197 - Remove a shim use from devtools tests.

Review commit: https://reviewboard.mozilla.org/r/86738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86738/

Comment 8

[:Gijs (he/him)]

Comment on attachment 8802319 [details]
Bug 1311197 - Remove CPOWs from some plugin mochitests.

https://reviewboard.mozilla.org/r/86732/#review85846

::: browser/base/content/test/plugins/browser_bug743421.js:92
(Diff revision 1)
>      let plugin = content.document.getElementsByTagName("embed")[1];
>      let objLoadingContent = plugin.QueryInterface(Ci.nsIObjectLoadingContent);
>      Assert.ok(objLoadingContent.activated, "Test 1d, Plugin should be activated");
> -  });
>  
> -  let promise = waitForEvent(gTestBrowser.contentWindow, "hashchange", null);
> +    let promise = ContentTaskUtils.waitForEvent(content, "hashchange")

Nit: missing semicolon.

Comment 9

[:Gijs (he/him)]

Comment on attachment 8802320 [details]
Bug 1311197 - Remove CPOWs from urlbar tests.

https://reviewboard.mozilla.org/r/86734/#review85854

Comment 10

[:Gijs (he/him)]

Comment on attachment 8802316 [details]
Bug 1311197 - Remove CPOWs from browser_bug611242.js.

https://reviewboard.mozilla.org/r/86726/#review85858

Comment 11

[:Gijs (he/him)]

Comment on attachment 8802317 [details]
Bug 1311197 - Remove CPOWs from browser_localfile2.js.

https://reviewboard.mozilla.org/r/86728/#review85860

Comment 12

[:Gijs (he/him)]

Comment on attachment 8802318 [details]
Bug 1311197 - Remove CPOWs from browser_bug655270.js.

https://reviewboard.mozilla.org/r/86730/#review85862

Comment 13

[:Gijs (he/him)]

Comment on attachment 8802321 [details]
Bug 1311197 - Remove CPOWs from docshell browser-chrome tests.

https://reviewboard.mozilla.org/r/86736/#review85864

::: docshell/test/browser/browser_tab_touch_events.js
(Diff revision 1)
> -  });
> -}
> -
> -function openUrl(url) {
> -  return new Promise(function(resolve, reject) {
> -    window.focus();

To keep this the same, behaviour-wise, I think we'd have to stick the window.focus() inside the add_task function?

I'm not sure why this test would need it, but it feels like removing this could potentially change behaviour, either for this or following tests. OTOH, perhaps we should find out rather than having undocumented 'magic' lying around in the test?

(not stealing this review because maybe Felipe knows more here - otherwise, r=me with the window.focus() call kept or an explanation why it's useless)

Comment 14

[:Gijs (he/him)]

Comment on attachment 8802322 [details]
Bug 1311197 - Remove a shim use from devtools tests.

https://reviewboard.mozilla.org/r/86738/#review85866

Comment 15

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8802321 [details]
Bug 1311197 - Remove CPOWs from docshell browser-chrome tests.

https://reviewboard.mozilla.org/r/86736/#review86300

Comment 16

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802316 [details]
Bug 1311197 - Remove CPOWs from browser_bug611242.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86726/diff/1-2/

Comment 17

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802317 [details]
Bug 1311197 - Remove CPOWs from browser_localfile2.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86728/diff/1-2/

Comment 18

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802318 [details]
Bug 1311197 - Remove CPOWs from browser_bug655270.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86730/diff/1-2/

Comment 19

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802319 [details]
Bug 1311197 - Remove CPOWs from some plugin mochitests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86732/diff/1-2/

Comment 20

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802320 [details]
Bug 1311197 - Remove CPOWs from urlbar tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86734/diff/1-2/

Comment 21

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802321 [details]
Bug 1311197 - Remove CPOWs from docshell browser-chrome tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86736/diff/1-2/

Comment 22

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802322 [details]
Bug 1311197 - Remove a shim use from devtools tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86738/diff/1-2/

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ce4a72010fa
Remove CPOWs from browser_bug611242.js. r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbd597046674
Remove CPOWs from browser_localfile2.js. r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/d30948200f18
Remove CPOWs from browser_bug655270.js. r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb3c939c1c22
Remove CPOWs from some plugin mochitests. r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/144e317c6fb2
Remove CPOWs from urlbar tests. r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d180c51943
Remove CPOWs from docshell browser-chrome tests. r=Gijs/felipe
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e998fdc243d
Remove a shim use from devtools tests. r=Gijs

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ce4a72010fa
https://hg.mozilla.org/mozilla-central/rev/fbd597046674
https://hg.mozilla.org/mozilla-central/rev/d30948200f18
https://hg.mozilla.org/mozilla-central/rev/eb3c939c1c22
https://hg.mozilla.org/mozilla-central/rev/144e317c6fb2
https://hg.mozilla.org/mozilla-central/rev/b9d180c51943
https://hg.mozilla.org/mozilla-central/rev/8e998fdc243d

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dbfd89fca407
https://hg.mozilla.org/releases/mozilla-aurora/rev/6f26a6f2bc8b
https://hg.mozilla.org/releases/mozilla-aurora/rev/585cdcd22000
https://hg.mozilla.org/releases/mozilla-aurora/rev/25e3131307ad
https://hg.mozilla.org/releases/mozilla-aurora/rev/590b78956218
https://hg.mozilla.org/releases/mozilla-aurora/rev/36f0a39347df
https://hg.mozilla.org/releases/mozilla-aurora/rev/cabfd3ce9af8