1311212 - Add dead CPOW debugging facility

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I found this useful while working on bug 1211270. It just forces a GC before handling any CPOW request.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Most of the work here is in holding strong references to CPOWs until the next turn of the event loop. When the parent finishes an event, it tells the child the ID of the last CPOW it saw. We assume that all CPOWs whose IDs are <= that number are eligible for collection in the child. CPOWs whose IDs are > that number are traced so they stay alive.

Without this strong reference thing, the debugging mode finds all sorts of problems that aren't real.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8802339 [details] [diff] [review]
patch

Review of attachment 8802339 [details] [diff] [review]:
-----------------------------------------------------------------

This is awesome.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99bf3401b43f
Add dead CPOW debugging facility (r=mrbkap)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/99bf3401b43f