1311214 - Remove b2g OMX encoder/decoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[(no longer active)]

Attachment: Remove b2g OMX encoder/decoder

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8802346 [details] [diff] [review]
Remove b2g OMX encoder/decoder

Review of attachment 8802346 [details] [diff] [review]:
-----------------------------------------------------------------

I'll let JW review this.

See also Bug 1307238, where we decided to keep the OMX Decoder Module.

Comment 3

[(no longer active)]

(In reply to Chris Pearce (:cpearce) from comment #2)
> See also Bug 1307238, where we decided to keep the OMX Decoder Module.

I can't reconcile this with the r+.  :-)

Should I land this patch?

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

The OMX Decoder Module is under dom/media/platforms/omx/ which you didn't change. So you can land the patch as is.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Why do we have both dom/media/platforms/omx and dom/media/platforms/gonk?

It looks like stuff in dom/media/platforms/gonk is setup to include dom/media/omx.

https://dxr.mozilla.org/mozilla-central/rev/01ab78dd98805e150b0311cce2351d5b408f3001/dom/media/platforms/gonk/moz.build#20

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Do you have any idea what dom/media/platforms/omx is for?

Comment 7

[Alfredo Yang (:alfredo)]

(In reply to JW Wang [:jwwang] [:jw_wang] from comment #6)
> Do you have any idea what dom/media/platforms/omx is for?

OpenMax for PDM. Community uses it, please keep it, bug 1306529.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

So what the community need is dom/media/platforms/omx instead of dom/media/platforms/gonk?
Does the community need dom/media/platforms/gonk as well?

Comment 9

[Alfredo Yang (:alfredo)]

(In reply to JW Wang [:jwwang] [:jw_wang] from comment #8)
> So what the community need is dom/media/platforms/omx instead of
> dom/media/platforms/gonk?
> Does the community need dom/media/platforms/gonk as well?

As far as I know, no.

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

OK. Then we can conclude that both dom/media/omx and dom/media/platforms/gonk can be removed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d084c1f34802
Remove b2g OMX encoder/decoder; r=cpearce

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d084c1f34802