Remove b2g OMX encoder/decoder

RESOLVED FIXED in Firefox 52

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: Away for a while, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

a year ago
Blocks: 1306391
(Reporter)

Comment 1

a year ago
Created attachment 8802346 [details] [diff] [review]
Remove b2g OMX encoder/decoder
Attachment #8802346 - Flags: review?(cpearce)
Component: DOM → Audio/Video: Playback
Comment on attachment 8802346 [details] [diff] [review]
Remove b2g OMX encoder/decoder

Review of attachment 8802346 [details] [diff] [review]:
-----------------------------------------------------------------

I'll let JW review this.

See also Bug 1307238, where we decided to keep the OMX Decoder Module.
Attachment #8802346 - Flags: review?(cpearce) → review?(jwwang)
Attachment #8802346 - Flags: review?(jwwang) → review+
(Reporter)

Comment 3

a year ago
(In reply to Chris Pearce (:cpearce) from comment #2)
> See also Bug 1307238, where we decided to keep the OMX Decoder Module.

I can't reconcile this with the r+.  :-)

Should I land this patch?
Flags: needinfo?(jwwang)
Flags: needinfo?(cpearce)
The OMX Decoder Module is under dom/media/platforms/omx/ which you didn't change. So you can land the patch as is.
Flags: needinfo?(jwwang)
Flags: needinfo?(cpearce)
Why do we have both dom/media/platforms/omx and dom/media/platforms/gonk?

It looks like stuff in dom/media/platforms/gonk is setup to include dom/media/omx.

https://dxr.mozilla.org/mozilla-central/rev/01ab78dd98805e150b0311cce2351d5b408f3001/dom/media/platforms/gonk/moz.build#20
Do you have any idea what dom/media/platforms/omx is for?
Flags: needinfo?(ayang)
(In reply to JW Wang [:jwwang] [:jw_wang] from comment #6)
> Do you have any idea what dom/media/platforms/omx is for?

OpenMax for PDM. Community uses it, please keep it, bug 1306529.
Flags: needinfo?(ayang)
So what the community need is dom/media/platforms/omx instead of dom/media/platforms/gonk?
Does the community need dom/media/platforms/gonk as well?
Flags: needinfo?(ayang)
(In reply to JW Wang [:jwwang] [:jw_wang] from comment #8)
> So what the community need is dom/media/platforms/omx instead of
> dom/media/platforms/gonk?
> Does the community need dom/media/platforms/gonk as well?

As far as I know, no.
Flags: needinfo?(ayang)
OK. Then we can conclude that both dom/media/omx and dom/media/platforms/gonk can be removed.

Comment 11

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d084c1f34802
Remove b2g OMX encoder/decoder; r=cpearce

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d084c1f34802
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Blocks: 1369194
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.