Closed
Bug 1311227
Opened 8 years ago
Closed 7 years ago
ffi_call not known to GC by the hazard analysis
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
|
3.31 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Bug 1306669 is from a rooting hazard that was not caught by the rooting analysis. The GC was coming underneath ffi_call, which is not known to GC because it invokes ffi_call_unix64, which is implemented in an assembly file unix64.S. The analysis only sees C/C++ compilation. ffi_call should be annotated to be a GC function.
|
Assignee | |
Comment 1•7 years ago
|
||
I've had this lying around for months for no reason.
Attachment #8821327 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sphink
Status: NEW → ASSIGNED
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8821327 [details] [diff] [review] Annotate ffi_call as a GC function Review of attachment 8821327 [details] [diff] [review]: ----------------------------------------------------------------- This looks great.
Attachment #8821327 -
Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7ab404ffffc6 Annotate ffi_call as a GC function, r=jonco
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7ab404ffffc6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•