Closed Bug 1311227 Opened 3 years ago Closed 3 years ago

ffi_call not known to GC by the hazard analysis

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1306669 is from a rooting hazard that was not caught by the rooting analysis. The GC was coming underneath ffi_call, which is not known to GC because it invokes ffi_call_unix64, which is implemented in an assembly file unix64.S. The analysis only sees C/C++ compilation.

ffi_call should be annotated to be a GC function.
I've had this lying around for months for no reason.
Attachment #8821327 - Flags: review?(jcoppeard)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Comment on attachment 8821327 [details] [diff] [review]
Annotate ffi_call as a GC function

Review of attachment 8821327 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great.
Attachment #8821327 - Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ab404ffffc6
Annotate ffi_call as a GC function, r=jonco
https://hg.mozilla.org/mozilla-central/rev/7ab404ffffc6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.