1311271 - The nsICacheStorage.asyncVisitStorage() and asyncEvictStorage() dose not obey originAttributes fully

Status: RESOLVED DUPLICATE of bug 1201042

(Core :: Networking: Cache, defect)

Description

[Tim Huang[:timhuang]]

The nsICacheStorage.asyncVisitStorage() only respects a part of originAttributes, including appId and inIsolatedMozBrowser. The [1] tells the reason why other attributes are ignored. We should make this API obeys the originAttributes.


[1] http://searchfox.org/mozilla-central/source/netwerk/cache2/CacheIndex.h#272

Comment 1

[Michal Novotny [:michal]]

Looks like a dupe of 1201042.

Comment 2

[Honza Bambas (:mayhemer)]

(In reply to Michal Novotny (:michal) from comment #1)
> Looks like a dupe of 1201042.

This can be fixed in the cache storage service implementation of the visiting mechanism.  Just do finer filtering via OA of the storage on each entry before serving it.  Not super efficient but better than what we have now.

Comment 3

[Honza Bambas (:mayhemer)]

Let's leave it untriaged, maybe we can find an owner soon.

Comment 4

[Honza Bambas (:mayhemer)]

Seems like the owner is going to be me, since we need to act now here.  Containers open another bug which effectively deletes the whole cache when a container only context is to be deleted.  See bug 1309695.

Comment 6

[Honza Bambas (:mayhemer)]

For reference, copying comment from Michal from other bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=1309695#c7

"The cache seems to be evicted due to this call:
  CacheStorageService::DoomStorageEntries [context=O^userContextId=5,]

IIUC, CacheIndex doesn't understand userContextId attribute, so it behaves like no context was specified."

Comment 7

[Honza Bambas (:mayhemer)]

Hmm.. after checking the code, the best possible solution would be to duplicate this to bug 1201042 and do a proper fix in the cache index.