1311346 - Update cubeb to revision 9eacd

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Paul Adenot (:padenot)]

This contains:
- Patches for the windows duplex fixes that were applied to gecko with patches, and removes the patch calls from `update.sh`
- Slightly change the device name on OSX, to use the data source and not the device name (so that it's more explicit when using the built-in mic or 3.5mm TRRS plug)
- Implement auto-swich for OSX and fix it for WASAPI. Those are temporary, we'll implement that properly soon
- Fix a ton of warning
- Implement a new logging mechanism that we'll be able to wire to MOZ_LOG (see bug 1311340)

Because upstream now uses CMake, and because CMake needs an export header, we create a new header downstream and make it define the necessary define.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1311346 - Update libcubeb to revision 9eacd3144.

Review commit: https://reviewboard.mozilla.org/r/86880/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86880/

Comment 2

[Paul Adenot (:padenot)]

Matthew, I saw on github upstream that you we're unsure about this new header. I'm happy to wait a cpuple days if we want to come up with a new solution (I can probably implement it if you don't have time), or we can just land this and remove this downstream header next time. I kind of need the new logging facility to diagnose errors in the field for a couple Nightly users.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8802494 [details]
Bug 1311346 - Update libcubeb to revision 9eacd3144.

https://reviewboard.mozilla.org/r/86880/#review86028

This is fine, I think having a dummy cubeb_export.h in Gecko is the simplest solution.

Comment 4

[Matthew Gregan [:kinetik]]

BTW, this update can also remove bug1308418-mutex-copy-ctor.patch and the update.sh change added in bug 1308418.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/657b9462cbec
Update libcubeb to revision 9eacd3144. r=kinetik

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1434b1b497b6
Add cubeb_export.h to the tree.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9831e7338e37
add cubeb_log.h to the tree

Comment 8

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #4)
> BTW, this update can also remove bug1308418-mutex-copy-ctor.patch and the
> update.sh change added in bug 1308418.

This patch and the other obsolete patches were left in place.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5172aa20ec83
Remove obsoleted patches.  r=me

Comment 10

[Paul Adenot (:padenot)]

Hrm I must have mixed up my trees, sorry about that.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/657b9462cbec
https://hg.mozilla.org/mozilla-central/rev/1434b1b497b6
https://hg.mozilla.org/mozilla-central/rev/9831e7338e37
https://hg.mozilla.org/mozilla-central/rev/5172aa20ec83