Closed Bug 1311346 Opened 5 years ago Closed 5 years ago
Update cubeb to revision 9eacd
58 bytes, text/x-review-board-request
This contains: - Patches for the windows duplex fixes that were applied to gecko with patches, and removes the patch calls from `update.sh` - Slightly change the device name on OSX, to use the data source and not the device name (so that it's more explicit when using the built-in mic or 3.5mm TRRS plug) - Implement auto-swich for OSX and fix it for WASAPI. Those are temporary, we'll implement that properly soon - Fix a ton of warning - Implement a new logging mechanism that we'll be able to wire to MOZ_LOG (see bug 1311340) Because upstream now uses CMake, and because CMake needs an export header, we create a new header downstream and make it define the necessary define.
Assignee: nobody → padenot
No longer blocks: 1311340
Matthew, I saw on github upstream that you we're unsure about this new header. I'm happy to wait a cpuple days if we want to come up with a new solution (I can probably implement it if you don't have time), or we can just land this and remove this downstream header next time. I kind of need the new logging facility to diagnose errors in the field for a couple Nightly users.
Comment on attachment 8802494 [details] Bug 1311346 - Update libcubeb to revision 9eacd3144. https://reviewboard.mozilla.org/r/86880/#review86028 This is fine, I think having a dummy cubeb_export.h in Gecko is the simplest solution.
Attachment #8802494 - Flags: review?(kinetik) → review+
BTW, this update can also remove bug1308418-mutex-copy-ctor.patch and the update.sh change added in bug 1308418.
Flags: needinfo?(kinetik) → needinfo?(padenot)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/657b9462cbec Update libcubeb to revision 9eacd3144. r=kinetik
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1434b1b497b6 Add cubeb_export.h to the tree.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/9831e7338e37 add cubeb_log.h to the tree
(In reply to Matthew Gregan [:kinetik] from comment #4) > BTW, this update can also remove bug1308418-mutex-copy-ctor.patch and the > update.sh change added in bug 1308418. This patch and the other obsolete patches were left in place.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5172aa20ec83 Remove obsoleted patches. r=me
Hrm I must have mixed up my trees, sorry about that.
You need to log in before you can comment on or make changes to this bug.