Closed Bug 1311362 Opened 5 years ago Closed 5 years ago

WebIDL maplike/setlike/iterable name collision checking mishandles ancestor interfaces

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names
9.68 KB, patch
qdot
: review+
Details | Diff | Splinter Review 
It always claims a collision on any member name on an ancestor!  See bug 1311198 comment 2.
Fixing this exposed the fact that the 'size' tests were passing quite accidentally, since we never added 'size' to the disallowed names sets.
Attachment #8802510 - Flags: review?(kyle)
Blocks: 1311198
Comment on attachment 8802510 [details] [diff] [review]
Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names

Review of attachment 8802510 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this!
Attachment #8802510 - Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adc8d8b7c967
Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names. r=qdot
https://hg.mozilla.org/mozilla-central/rev/adc8d8b7c967
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.