WebIDL maplike/setlike/iterable name collision checking mishandles ancestor interfaces

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

It always claims a collision on any member name on an ancestor!  See bug 1311198 comment 2.
Created attachment 8802510 [details] [diff] [review]
Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names

Fixing this exposed the fact that the 'size' tests were passing quite accidentally, since we never added 'size' to the disallowed names sets.
Attachment #8802510 - Flags: review?(kyle)
Comment on attachment 8802510 [details] [diff] [review]
Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names

Review of attachment 8802510 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this!
Attachment #8802510 - Flags: review?(kyle) → review+

Comment 3

2 years ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adc8d8b7c967
Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names. r=qdot

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/adc8d8b7c967
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.