Closed
Bug 1311362
Opened 9 years ago
Closed 9 years ago
WebIDL maplike/setlike/iterable name collision checking mishandles ancestor interfaces
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
It always claims a collision on any member name on an ancestor! See bug 1311198 comment 2.
|
Assignee | |
Comment 1•9 years ago
|
||
Fixing this exposed the fact that the 'size' tests were passing quite accidentally, since we never added 'size' to the disallowed names sets.
Attachment #8802510 -
Flags: review?(kyle)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8802510 [details] [diff] [review]
Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names
Review of attachment 8802510 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for taking care of this!
Attachment #8802510 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adc8d8b7c967
Fix webidl member name collision checking with ancestor interfaces to not claim name collisions on totally unrelated names. r=qdot
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•