1311465 - Replace uses of django-memoize with django's default cache

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[William Lachance (:wlach)]

I used django-memoize for the first pass at caching the bug suggestions, but this doesn't seem like a particularly good fit given the complexity of the caching logic we have for this use case. Let's just switch back to the default django cache to make things easier to reason about.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1311465 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8802658 [details] [review]
[treeherder] wlach:1311465 > mozilla:master

I don't think this will fix the problem where we're still hitting the database (or if it does, I'm not sure how it will), but I think it's easier to understand than what we had before.

Comment 3

[William Lachance (:wlach)]

Morphing bug description to encompass getting rid of django-memoize altogether.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8802658 [details] [review]
[treeherder] wlach:1311465 > mozilla:master

The expanded scope probably merits a new r?, hopefully the changes are straightforward to review.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e6ef630d8453961ea1ca25abb84aaef54fcccd6f
Bug 1311465 - Replace uses of django-memoize with django's default cache (#1937)

It turns out that django-memoize's behaviour is rather difficult to reason
about for common cases, so let's just use django's cache framework for now.