Closed Bug 1311528 Opened 5 years ago Closed 5 years ago

Some tests reported as java-exception failures are in other processes

Categories

(Firefox for Android Graveyard :: Testing, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file, 1 obsolete file)

Our Android test harnesses check the logcat for "FATAL EXCEPTION" and report a failure if that is found. Most (all?) of these failures are in other processes - typically Android system processes. For example, see bug 1291974.

While there is a chance that the FATAL EXCEPTION causes a test failure - as seen in the original use case in bug 872116 - it appears that many of these system failures are unrelated to Firefox. I think it would be better not to scan for FATAL EXCEPTION.
Oh, wow, so this could be the reason for a lot of intermittent failures we see, right?
Actually, I reviewed all of our "java-exception" bugs and found only a few cases of "FATAL EXCEPTION"; all of the existing unresolved java-exception bugs are based on "REPORTING UNCAUGHT EXCEPTION", which is reported by Firefox code.
Attachment #8802908 - Flags: review?(jmaher)
Comment on attachment 8802908 [details] [diff] [review]
do not trigger java-exception on "FATAL EXCEPTION"

Oops, forgot to update the test...
Attachment #8802908 - Flags: review?(jmaher)
Attachment #8802908 - Attachment is obsolete: true
Comment on attachment 8802924 [details] [diff] [review]
do not trigger java-exception on "FATAL EXCEPTION"

Review of attachment 8802924 [details] [diff] [review]:
-----------------------------------------------------------------

nice and simple.
Attachment #8802924 - Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/733063079b8e
Do not report java-exception on "FATAL EXCEPTION"; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/733063079b8e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.