1311528 - Some tests reported as java-exception failures are in other processes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

Our Android test harnesses check the logcat for "FATAL EXCEPTION" and report a failure if that is found. Most (all?) of these failures are in other processes - typically Android system processes. For example, see bug 1291974.

While there is a chance that the FATAL EXCEPTION causes a test failure - as seen in the original use case in bug 872116 - it appears that many of these system failures are unrelated to Firefox. I think it would be better not to scan for FATAL EXCEPTION.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Oh, wow, so this could be the reason for a lot of intermittent failures we see, right?

Comment 2

[Geoff Brown [:gbrown]]

Actually, I reviewed all of our "java-exception" bugs and found only a few cases of "FATAL EXCEPTION"; all of the existing unresolved java-exception bugs are based on "REPORTING UNCAUGHT EXCEPTION", which is reported by Firefox code.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: do not trigger java-exception on "FATAL EXCEPTION"

Comment 4

[Geoff Brown [:gbrown]]

Comment on attachment 8802908 [details] [diff] [review]
do not trigger java-exception on "FATAL EXCEPTION"

Oops, forgot to update the test...

Comment 5

[Geoff Brown [:gbrown]]

Attachment: do not trigger java-exception on "FATAL EXCEPTION"

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8802924 [details] [diff] [review]
do not trigger java-exception on "FATAL EXCEPTION"

Review of attachment 8802924 [details] [diff] [review]:
-----------------------------------------------------------------

nice and simple.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/733063079b8e
Do not report java-exception on "FATAL EXCEPTION"; r=jmaher

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/733063079b8e