1311604 - consider block flow direction in vertical writing mode native widget layout

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Karl Tomlinson (:karlt)]

The reftests for bug 1302389 notice that vertical scrollbars are drawn for the
bidi text direction even when the writing mode is vertical.

See for example
https://treeherder.mozilla.org/logviewer.html#?job_id=5334765&repo=mozilla-central#L13987

The thumb (orange) should be on the outside (when not in hover).

Comment 1

[Karl Tomlinson (:karlt)]

Last failure blocking unhiding Linux reftests.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: bug 1311604 consider block flow direction in vertical writing mode native widget layout

This follows the same approach of considering block flow for all widgets
(in addition to resizers) as done for other toolkits in
https://hg.mozilla.org/mozilla-central/rev/4a65cacf8a37#l3.10

Review commit: https://reviewboard.mozilla.org/r/87118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87118/

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8802816 [details]
bug 1311604 consider block flow direction in vertical writing mode native widget layout

https://reviewboard.mozilla.org/r/87118/#review86148

I haven't looked for specific examples where this makes a difference to other widgets in Gtk (presumably it can depend on details of the theme), but in general it seems like the most reasonable thing to do.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd7cb9b5537a
consider block flow direction in vertical writing mode native widget layout r=jfkthame

Comment 5

[Guilherme Lima]

Landed 22 hours ago https://hg.mozilla.org/mozilla-central/rev/bd7cb9b5537a