Closed Bug 1311604 Opened 3 years ago Closed 3 years ago

consider block flow direction in vertical writing mode native widget layout

Categories

(Core :: Widget: Gtk, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The reftests for bug 1302389 notice that vertical scrollbars are drawn for the
bidi text direction even when the writing mode is vertical.

See for example
https://treeherder.mozilla.org/logviewer.html#?job_id=5334765&repo=mozilla-central#L13987

The thumb (orange) should be on the outside (when not in hover).
Last failure blocking unhiding Linux reftests.
Blocks: 789103
Priority: -- → P1
Comment on attachment 8802816 [details]
bug 1311604 consider block flow direction in vertical writing mode native widget layout

https://reviewboard.mozilla.org/r/87118/#review86148

I haven't looked for specific examples where this makes a difference to other widgets in Gtk (presumably it can depend on details of the theme), but in general it seems like the most reasonable thing to do.
Attachment #8802816 - Flags: review?(jfkthame) → review+
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd7cb9b5537a
consider block flow direction in vertical writing mode native widget layout r=jfkthame
Flags: in-testsuite+
Blocks: 1311916
Landed 22 hours ago https://hg.mozilla.org/mozilla-central/rev/bd7cb9b5537a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.