Closed
Bug 1311614
Opened 8 years ago
Closed 8 years ago
Move CustomRequestView to its own module
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox52 fixed)
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: gasolin, Assigned: gasolin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [netmonitor])
Attachments
(2 files)
Move the CustomRequestView class out of netmonitor-view.js into its own module. Move shared functions and constants to shared modules as needed.
Flags: qe-verify?
|
||
Updated•8 years ago
|
Whiteboard: [netmonitor] → [netmonitor] [triage]
|
|
||
Updated•8 years ago
|
Assignee: gasolin → nobody
Status: ASSIGNED → NEW
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
|
|
||
Updated•8 years ago
|
Iteration: --- → 52.3 - Nov 7
Priority: -- → P1
Whiteboard: [netmonitor] [triage] → [netmonitor]
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•8 years ago
|
||
try green. I can't find CustomRequestView.populate is called anywhere, though the related event(EVENTS.CUSTOMREQUESTVIEW_POPULATED) is used in test cases, so I keep it unchanged. We can figure it out when we convert it to the react component.
|
|
Assignee | |
Comment 5•8 years ago
|
||
Ok, `CustomRequestView.populate` is called by `NetmonitorView._onTabSelect`, which will call view's populate method when switching to the target tab. So `CustomRequestView.populate` is functional.
|
|
||
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8802838 [details] Bug 1311614 - Move CustomRequestView to its own module; https://reviewboard.mozilla.org/r/87134/#review86534 LGTM! R+ assuming try is green. Honza
Attachment #8802838 -
Flags: review?(odvarko) → review+
| Comment hidden (mozreview-request) |
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6434461d1252 Move CustomRequestView to its own module;r=Honza
Keywords: checkin-needed
|
||
Comment 10•8 years ago
|
||
This broke eslint which was unfortunately hidden over the weekend: TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/client/netmonitor/custom-request-view.js:216:2 | Newline required at end of file but not found. (eol-last) Its simple, so I'll get a bustage fix for it landed in a moment.
| Comment hidden (mozreview-request) |
|
|
||
Updated•8 years ago
|
Attachment #8803806 -
Flags: review+
|
|
||
Comment 12•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8803806 [details] Follow up to bug 1311614 - Fix missing newline at end of custom-request-view.js to fix eslint. rs=bustage-fix. https://reviewboard.mozilla.org/r/87962/#review86940 rs=Standard8
|
||
Comment 13•8 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47efa3e76f69 Follow up to bug 1311614 - Fix missing newline at end of custom-request-view.js to fix eslint. rs=bustage-fix. r=standard8
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6434461d1252 https://hg.mozilla.org/mozilla-central/rev/47efa3e76f69
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•