Closed Bug 1311673 Opened 3 years ago Closed 3 years ago
Document::Image Resizing Enabled is unused
https://dxr.mozilla.org/mozilla-central/search?q=imageresizingenabled AFAICT it always returns true, but nobody actually calls either the XPIDL or webidl implementations anywhere, so we're just shipping dead stuff. I found exactly 1 add-on "using" this read-only prop: https://addons.mozilla.org/en-US/firefox/addon/browse-images/ - but afaict that function gets called in exactly 1 circumstance, namely if the image width and height are both exactly 24 pixels. That seems like buggy code - I don't think that justifies keeping our dead bits around.
Edgar, this seems in your wheelhouse :)
Hi Olli, I am willing to take this bug to remove ImageDocument.imageResizingEnabled, but it might cause add-on compatibility problems, although there seems only one add-on using this prop. How do we usually deal with this situation?
Flags: needinfo?(echen) → needinfo?(bugs)
jorge could answer to that. Is the addon which is using this updated recently? Is it compatible with current FF release?
Flags: needinfo?(bugs) → needinfo?(jorge)
I think you could also just contact the addon author and ask whether it is ok to remove the property.
It's a very old add-on, probably abandoned. I'll include this in the compat communication, but the impact is minimal, so please go ahead with it.
Thanks for the comments, Jorge and Olli.
Assignee: nobody → echen
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cb5e3d3e9596 Remove ImageDocument::ImageResizingEnabled. r=smaug
You need to log in before you can comment on or make changes to this bug.