Note: There are a few cases of duplicates in user autocompletion which are being worked on.

ImageDocument::ImageResizingEnabled is unused

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: Gijs, Assigned: edgar)

Tracking

({addon-compat})

Trunk
mozilla52
addon-compat
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
https://dxr.mozilla.org/mozilla-central/search?q=imageresizingenabled

AFAICT it always returns true, but nobody actually calls either the XPIDL or webidl implementations anywhere, so we're just shipping dead stuff. I found exactly 1 add-on "using" this read-only prop:

https://addons.mozilla.org/en-US/firefox/addon/browse-images/ - but afaict that function gets called in exactly 1 circumstance, namely if the image width and height are both exactly 24 pixels. That seems like buggy code - I don't think that justifies keeping our dead bits around.
Edgar, this seems in your wheelhouse :)
Flags: needinfo?(echen)
Hi Olli, I am willing to take this bug to remove ImageDocument.imageResizingEnabled, but it might cause add-on compatibility problems, although there seems only one add-on using this prop. How do we usually deal with this situation?
Flags: needinfo?(echen) → needinfo?(bugs)

Comment 3

9 months ago
jorge could answer to that.

Is the addon which is using this updated recently? Is it compatible with current FF release?
Flags: needinfo?(bugs) → needinfo?(jorge)

Comment 4

9 months ago
I think you could also just contact the addon author and ask whether it is ok to remove the property.
It's a very old add-on, probably abandoned. I'll include this in the compat communication, but the impact is minimal, so please go ahead with it.
Flags: needinfo?(jorge)
Keywords: addon-compat
Thanks for the comments, Jorge and Olli.
Assignee: nobody → echen
Created attachment 8807031 [details] [diff] [review]
Patch, v1
Attachment #8807031 - Flags: review?(bugs)
Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c9773dd659d6c6015cd1c7fc03babeb7302e98b&group_state=expanded&filter-tier=1

Updated

9 months ago
Attachment #8807031 - Flags: review?(bugs) → review+
Keywords: checkin-needed

Comment 9

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb5e3d3e9596
Remove ImageDocument::ImageResizingEnabled. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cb5e3d3e9596
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.