1311673 - ImageDocument::ImageResizingEnabled is unused

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Gijs (he/him)]

https://dxr.mozilla.org/mozilla-central/search?q=imageresizingenabled

AFAICT it always returns true, but nobody actually calls either the XPIDL or webidl implementations anywhere, so we're just shipping dead stuff. I found exactly 1 add-on "using" this read-only prop:

https://addons.mozilla.org/en-US/firefox/addon/browse-images/ - but afaict that function gets called in exactly 1 circumstance, namely if the image width and height are both exactly 24 pixels. That seems like buggy code - I don't think that justifies keeping our dead bits around.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Edgar, this seems in your wheelhouse :)

Comment 2

[Edgar Chen [:edgar] (PTO until 02/09)]

Hi Olli, I am willing to take this bug to remove ImageDocument.imageResizingEnabled, but it might cause add-on compatibility problems, although there seems only one add-on using this prop. How do we usually deal with this situation?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

jorge could answer to that.

Is the addon which is using this updated recently? Is it compatible with current FF release?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I think you could also just contact the addon author and ask whether it is ok to remove the property.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

It's a very old add-on, probably abandoned. I'll include this in the compat communication, but the impact is minimal, so please go ahead with it.

Comment 6

[Edgar Chen [:edgar] (PTO until 02/09)]

Thanks for the comments, Jorge and Olli.

Comment 7

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Patch, v1

Comment 8

[Edgar Chen [:edgar] (PTO until 02/09)]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c9773dd659d6c6015cd1c7fc03babeb7302e98b&group_state=expanded&filter-tier=1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb5e3d3e9596
Remove ImageDocument::ImageResizingEnabled. r=smaug

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cb5e3d3e9596