system addons blob needs to handle blobs without "addons" in them more gracefully

RESOLVED FIXED

Status

Release Engineering
Balrog: Backend
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Right now, we access "addons" without checking for its existence in many places. This is a bad assumption, because "addons" are not a required part of the blob. A simple self.get() or "if addons in self" guard should be enough.
(Assignee)

Comment 1

7 months ago
Created attachment 8804042 [details] [review]
fix bad lookups in SystemAddonsBlob
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8804042 - Flags: review?(rail)
Attachment #8804042 - Flags: review?(rail) → review+

Comment 2

7 months ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/351dfa395752160420bec261d804a997b63d5748
bug 1311730: Gracefully handle missing addons section (#162). r=rail
(Assignee)

Updated

7 months ago
Depends on: 1312772
(Assignee)

Comment 3

7 months ago
This is in production.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.