Closed Bug 1311730 Opened 8 years ago Closed 8 years ago

system addons blob needs to handle blobs without "addons" in them more gracefully

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file)

fix bad lookups in SystemAddonsBlob
42 bytes, text/x-github-pull-request
rail
: review+
Details | Review 
Right now, we access "addons" without checking for its existence in many places. This is a bad assumption, because "addons" are not a required part of the blob. A simple self.get() or "if addons in self" guard should be enough.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED

        Attachment #8804042 -
        Flags: review?(rail)

    
  

        Attachment #8804042 -
        Flags: review?(rail) → review+

    
    

    
  
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/351dfa395752160420bec261d804a997b63d5748
bug 1311730: Gracefully handle missing addons section (#162). r=rail

    
  
Depends on: 1312772

    
    

    
  
This is in production.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

    
  
Product: Release Engineering → Release Engineering Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: