1311743 - don't check property validity on the client

Status: NEW

(DevTools :: Inspector, defect, P3)

Description

[Tom Tromey :tromey]

In bug 1265796 and bug 1291866 we tried to replace domutils.cssPropertyIsValid
with new methods on the actor.  However, this attempt failed, and in the end we
reverted to doing validity checks on the client.

This is ok but still incorrect.  It would be better for the inspector to ask
the server instead.  This is difficult primarily due to the need to introduce
async calls in many places that are currently sync.

Comment 1

[Patrick Brosset <:pbro>]

Tom, does it make sense to still track this in the scope of the devtools-html project (in phase 2) or is this simply a way for us to remember and revisit the decision at a later stage (after the project is over)?

- If it's part of the current html project, then please add the right whiteboard flags so it shows up on Marco's radar.
- Otherwise, please help me triage this bug. Is this a refactoring we should do next quarter, later?

Comment 2

[Tom Tromey :tromey]

(In reply to Patrick Brosset <:pbro> from comment #1)
> Tom, does it make sense to still track this in the scope of the
> devtools-html project (in phase 2) or is this simply a way for us to
> remember and revisit the decision at a later stage (after the project is
> over)?

This is a reminder for later.

> - Otherwise, please help me triage this bug. Is this a refactoring we should
> do next quarter, later?

I tend to think it's a low priority.  It's hard to picture doing this refactoring
for its own sake, as the impact is rather obscure (since I think few people are
doing anything other than "native" inspecting).  If/when the rule view moves to
React, though, I would expect fixing this to be one of the desired outcomes.

Comment 3

[Patrick Brosset <:pbro>]

Thanks Tom.

Comment 4

[Tom Tromey :tromey]

I found a new instance of this -- OutputParser now looks at a local pref to decide if
grid is enabled:

https://dxr.mozilla.org/mozilla-central/rev/f179934df0c1bab590c558485d419c7910e41325/devtools/client/shared/output-parser.js#202

This should be queried on the server instead.

Comment 5

[Tom Tromey :tromey]

(In reply to Tom Tromey :tromey from comment #4)
> I found a new instance of this -- OutputParser now looks at a local pref to
> decide if
> grid is enabled:

I think this has to be fixed for devtools-html, so I filed bug 1328625.