1311779 - Image decoders should use B8G8R8X8 if possible

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

JPEG and BMP decoders do not start in B8G8R8X8 and rely upon an optimization later to use the correct format. We should also add telemetry to track how frequently this optimization would be used (even if disabled at present due to issues bug 1290293 is fixing) to decide if it is even necessary with the changes in this bug.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Part 1. Start in BGRX if possible, v1

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Part 2. Add telemetry, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7366ebed42cb33edcf423b7847ce09c06c80570b

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Part 2. Add telemetry, v2

Change it to expire in 53 (we shouldn't need to run the collection for long).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cea19368e06
Part 1. Ensure JPEG and BMP image decoders use B8G8R8X8 surfaces when possible. r=tnikkel
https://hg.mozilla.org/integration/mozilla-inbound/rev/36b7546597dc
Part 2. Add telemetry to track optimizable opaque images decoded into B8G8R8A8 surfaces. r=tnikkel

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1cea19368e06
https://hg.mozilla.org/mozilla-central/rev/36b7546597dc