If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Image decoders should use B8G8R8X8 if possible

RESOLVED FIXED in Firefox 52

Status

()

Core
ImageLib
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 months ago
JPEG and BMP decoders do not start in B8G8R8X8 and rely upon an optimization later to use the correct format. We should also add telemetry to track how frequently this optimization would be used (even if disabled at present due to issues bug 1290293 is fixing) to decide if it is even necessary with the changes in this bug.
(Assignee)

Updated

11 months ago
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
(Assignee)

Comment 1

11 months ago
Created attachment 8803040 [details] [diff] [review]
Part 1. Start in BGRX if possible, v1
(Assignee)

Comment 2

11 months ago
Created attachment 8803046 [details] [diff] [review]
Part 2. Add telemetry, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7366ebed42cb33edcf423b7847ce09c06c80570b
(Assignee)

Updated

11 months ago
Blocks: 1290293
(Assignee)

Comment 3

11 months ago
Created attachment 8806015 [details] [diff] [review]
Part 2. Add telemetry, v2

Change it to expire in 53 (we shouldn't need to run the collection for long).
Attachment #8803046 - Attachment is obsolete: true
(Assignee)

Updated

11 months ago
Attachment #8803040 - Flags: review?(tnikkel)
(Assignee)

Updated

11 months ago
Attachment #8806015 - Flags: review?(tnikkel)

Updated

11 months ago
Attachment #8803040 - Flags: review?(tnikkel) → review+

Updated

11 months ago
Attachment #8806015 - Flags: review?(tnikkel) → review+

Comment 4

11 months ago
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cea19368e06
Part 1. Ensure JPEG and BMP image decoders use B8G8R8X8 surfaces when possible. r=tnikkel
https://hg.mozilla.org/integration/mozilla-inbound/rev/36b7546597dc
Part 2. Add telemetry to track optimizable opaque images decoded into B8G8R8A8 surfaces. r=tnikkel

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1cea19368e06
https://hg.mozilla.org/mozilla-central/rev/36b7546597dc
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.