1311810 - Use gecko-t-* workers for gecko tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

These are currently desktop-test-*, and should be replaced with properly-named workerTypes.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Haard -- do you want to try this out, too?  It's similar to bug 1307771 where you did such a great job!

Comment 2

[HAMMAD AKHTAR]

Hey Dustin I would like to get assigned to this bug. Where can I start ?

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Have a look at bug 1307771 for the general approach here.  The idea will be to replace workerTypes for all test jobs in this case.  I can take care of setting up the new workerTypes when the time comes.

Comment 4

[HAMMAD AKHTAR]

Attachment: changing desktop-test-* to gecko-t*

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8812403 [details] [diff] [review]
changing desktop-test-* to gecko-t*

Review of attachment 8812403 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good!

Having a look at https://tools.taskcluster.net/aws-provisioner/ which lists our workerTypes, I see gecko-t-win*.  Let's use gecko-t-linux* here, instead.  I'll change that while landing your patch instead of asking for a new patch.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Hm, something's odd with that patch -- it's missing the end of some lines, and should have more lines at the bottom.  Was that the output of 'hg diff'?

Comment 7

[HAMMAD AKHTAR]

(In reply to Dustin J. Mitchell [:dustin] from comment #6)
> Hm, something's odd with that patch -- it's missing the end of some lines,
> and should have more lines at the bottom.  Was that the output of 'hg diff'?

hg diff shows some more lines at the end I just pasted relevant parts in the patch.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85c10485cbc2

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

That's (sort of) OK for review, but doesn't work when I try to land the patch.  Using mozreview is best, but if not, it's important to capture all of the diff output.  If this try job works, I'll land the patch.

Comment 10

[HAMMAD AKHTAR]

(In reply to Dustin J. Mitchell [:dustin] from comment #9)
> That's (sort of) OK for review, but doesn't work when I try to land the
> patch.  Using mozreview is best, but if not, it's important to capture all
> of the diff output.  If this try job works, I'll land the patch.
I can push the patch on mozreview if you want ?

Comment 11

[HAMMAD AKHTAR]

Attachment: Bug 1311810 - Use gecko-t-* workers for gecko tests

Review commit: https://reviewboard.mozilla.org/r/94686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94686/

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8813160 [details]
Bug 1311810 - Use gecko-t-* workers for gecko tests

https://reviewboard.mozilla.org/r/94686/#review94892

Thanks for the mozreview!

However, the tests on this try push will not run, because the workerTypes have a different name (gecko-t-linux-{xlarge,large,medium}).  I used that different name in https://treeherder.mozilla.org/#/jobs?repo=try&revision=85c10485cbc2 which succeeded.  So I'll land that patch.

Drop by in #tc-contributors sometime today and we'll see what you want to work on next!

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35292375aab329745599e0814ab11baafa61ecf0
Bug 1311810: changing desktop-test-* to gecko-t*; r=dustin

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/35292375aab3

Comment 15

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8813160 [details]
Bug 1311810 - Use gecko-t-* workers for gecko tests

Approval Request Comment
[Feature/Bug causing the regression]:

aurora and beta are using the old workerTypes, and since runs on those workerTypes are few and far between, it takes a while to start the instances up -- meaning longer wait times for these repos.

[User impact if declined]: slower tests

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]:  no

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: been running in central for a long time

[String changes made/needed]: none

Comment 16

[Julien Cristau [:jcristau]]

This is not part of the build, I don't think it needs relman approval.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Don't reopen bugs if they're fixed on trunk. Status flags are used to track uplifts.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/735074bc84c3

Comment 19

[Carsten Book [:Tomcat]]

needs rbasing for beta

Comment 20

[HAMMAD AKHTAR]

to which changeset should I rebase ?

Comment 21

[Dustin J. Mitchell [:dustin] (he/him)]

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial#mozilla-beta_(prerelease_development_tree)

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5875f0a84530