Crash in java.lang.SecurityException: "passive" location provider requires ACCESS_FINE_LOCATION permission. at android.os.Parcel.readException(Parcel.java)

NEW
Unassigned

Status

()

Firefox for Android
GeckoView
P3
critical
2 years ago
2 months ago

People

(Reporter: mccr8, Unassigned)

Tracking

({crash})

unspecified
Unspecified
Android
crash
Points:
---

Firefox Tracking Flags

(firefox58 affected)

Details

(crash signature)

(Reporter)

Description

2 years ago
This bug was filed from the Socorro interface and is 
report bp-2b2f0743-781d-4e2a-9891-b38132161020.
=============================================================

This was the top Android crash on the 10-20 Nightly, but it is all from a single install time. I only see 29 crashes like this across all version, but it looked like it might be easy to fix.
bp-b413cca7-eb9a-40e8-89bf-e41310180303 

Ignoring the crash reports from ancient Fennec versions, there were 26 crash reports from Fennec 58.0.2 on at least four different devices over the last week.

Why doesn't Fennec have the ACCESS_FINE_LOCATION permission here? The crashing function (getLastKnownLocation) has an annotation to @SuppressLint("MissingPermission"), so some lint warned us about this problem. Jim added this code in bug 1369107 with a comment saying "Permissions are explicitly checked when requesting content permission."

https://searchfox.org/mozilla-central/rev/44fa24847e4e73ce8932de4c8cf47559302e4ba2/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java#293
Blocks: 1369107
status-firefox58: --- → affected
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.