131190 - MsgSendLater need to address the X-DraftInfo receipt info recorded in the send later message

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Jeff Tsai]

The scheme of recording return receipt information in X-DraftInfo has been 
changed for current implementation of MDN return receipt. Need to address it 
correctly.

Comment 1

[Jeff Tsai]

Accepting ...

Comment 2

[Jeff Tsai]

Attachment: Patch to correctly pick up return receipt draft info

Coded but not tested due to the problem of bug 134521.

Comment 3

[Jeff Tsai]

Attachment: Patch for clean up; there is no problem to fix

It turns out that it's not a problem because we already have the final header
generated. Instead, some of code are not needed. We just need to make sure to
strip off those private X-SomeHeaders. Please review and senior review if we
ever want to do some clean up works.

Comment 4

[David :Bienvenu]

Comment on attachment 77401 [details] [diff] [review]
Patch for clean up; there is no problem to fix

r=bienvenu

Comment 5

[Jean-Francois Ducarroz]

R=ducarroz. Bienvenu, can you change you R for a SR?

Comment 6

[David :Bienvenu]

Comment on attachment 77401 [details] [diff] [review]
Patch for clean up; there is no problem to fix

ok, r=ducarroz, sr=bienvenu

Comment 7

[scottputterman]

What's the bug that the user sees because of this?

Comment 8

[Jeff Tsai]

There is no bug. It turns out we don't not need to do anything to it except for
clean ups.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 77401 [details] [diff] [review]
Patch for clean up; there is no problem to fix


This patch has a little bitrotted;
but otherwise, appears ready for check-in.

Can anyone check it in ? Thanks.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: unbitrotted patch

Bienvenu, can you take a look at this again, given that this patch is so old? This is the same patch as before, but unbitrotted.

Comment 11

[David :Bienvenu]

Comment on attachment 244808 [details] [diff] [review]
unbitrotted patch

looks OK, as long as drafts that are sent later still request mdn properly.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/compose/src/nsMsgSendLater.cpp 	1.107
mozilla/mailnews/compose/src/nsMsgSendLater.h 	1.29