1311924 - Handle play state changes in state objects of MDSM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

This allow different policy for different state objects. E.g. we want DecodingState to enter dormant aggressively when playback is paused for a long time.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1311924 - Handle play state changes in state objects of MDSM.

Note we remove the comments that are no longer valid and we call
ScheduleStateMachine() only for DecodingState and CompletedState.

1. DecodingFirstFrameState doesn't implement Step(). It doesn't
make sense to schedule next cycles.

2. BufferingState doesn't care about the play state since it will
never start playback.

Review commit: https://reviewboard.mozilla.org/r/88792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88792/

Comment 2

[Tzuhao Kuo [:kaku]]

Comment on attachment 8804969 [details]
Bug 1311924 - Handle play state changes in state objects of MDSM.

https://reviewboard.mozilla.org/r/88792/#review88026

Why don't we implement HandlePlayStateChanged() for the BufferingState?

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8804969 [details]
Bug 1311924 - Handle play state changes in state objects of MDSM.

https://reviewboard.mozilla.org/r/88792/#review88028

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e8ddc7e6575
Handle play state changes in state objects of MDSM. r=kaku

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3e8ddc7e6575