Closed Bug 1311934 Opened 5 years ago Closed 6 months ago

TextServicesDocument::IsBlockNode() returns true when the given content isn't an element node

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox52 --- wontfix
firefox92 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

nsTextServicesDocument::IsBlockNode() returns true even when the given node isn't an element node. For example, it returns true for a text node.
Priority: -- → P3
Mass wontfix for bugs affecting firefox 52.

Resetting assignee which I don't work on in this several months.

Assignee: masayuki → nobody
Summary: nsTextServicesDocument::IsBlockNode() returns true when the given content isn't an element node → TextServicesDocument::IsBlockNode() returns true when the given content isn't an element node
Assignee: nobody → masayuki
Status: NEW → ASSIGNED

For consistency, between TextServicesDocument and HTMLEditor,
TextServicesDocument::IsBlockNode() should be replaced with
HTMLEditUtils::IsBlockElement() for making same consideration for each
element type.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/cb4ce47cb878
Replace `TextServicesDocument::IsBlockNode()` with `HTMLEditUtils::IsBlockElement()` r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.