1312020 - Download Panel Glitches when removing an item from History

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

[Affected platforms]:

 Windows 10 x64
 Windows 10 x32
 Windows 8.1 x64
 Ubuntu 14.04 LTS
 Mac OS X 10.10.5

[Steps to reproduce]:

 1. Launch Firefox.
 2. Go to " http://www.thinkbroadband.com/download.html ".
 3. Download multiple files.
 4. Cancel (if needed) one download and right click it.
 5. Select "Remove from history".
 6. Redo steps 4 and 5.

[Expected result]:

 The selected download are removed from history without any issues.

[Actual result]:

 After removing from history there is a small glitch.

[Additional notes]:

 a. This issue is reproducible 100%, in the attachment the Gif recorder only caught it the first time.
 b. Gif with the issue: http://imgur.com/a/HqDbf .

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Drew, Paolo, I think we uplifted a few fixes in this area during Aurora50 cycle. Could you please investigate? I am not planning to block 50.0b9 build on this issue as I don't believe this is a recent regression since 50.0b8.

Comment 2

[Drew Willcoxon :adw]

I think we decided to accept the flicker for now in bug 1292345 -- see https://bugzilla.mozilla.org/show_bug.cgi?id=1206233#c59

Paolo is working on bug 1009116 for a better way to resize the panel without the flickering.

I'll leave the needinfo on Paolo in case he has other thoughts.

Comment 3

[Bogdan Maris, Desktop QA]

Used mozregression to track town the regression here, this are the results:

m-c:

[2016-07-28, 2016-07-29]
Last good revision: db3ed1fdbbeaf5ab1e8fe454780146e7499be3db (2016-07-28)
First bad revision: 2ea3d51ba1bb9f5c3b6921c43ea63f70b4fdf5d2 (2016-07-29)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=db3ed1fdbbeaf5ab1e8fe454780146e7499be3db&tochange=2ea3d51ba1bb9f5c3b6921c43ea63f70b4fdf5d2

m-i
Last good revision: 4dc4d45c2115f8805f15e10c0bf0e776408af0d2
First bad revision: 58feaa721b44b75919423d89b359d8bb67ea7051
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4dc4d45c2115f8805f15e10c0bf0e776408af0d2&tochange=58feaa721b44b75919423d89b359d8bb67ea7051

Possible culprit:
5f273e4bdc67	Drew Willcoxon — Bug 1280709 - Downloads panel's "Show All Downloads" menu item is no longer clickable below its text label. r=gijs

Comment 4

[Drew Willcoxon :adw]

I think I answered this in comment 2.  Is there something else you need?

Comment 5

[Andrew Overholt [:overholt]]

Given the perceived low impact here (at least IMHO), I'm going to mark this fix-optional for 50.

Comment 6

[:Paolo Amadini]

This will be fixed by bug 1009116, marking as a dependency.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Seems highly unlikely to me that we'd backport a fix like bug 1009116, so marking older releases as wontfix.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 53, as we are in the last week of the 53 beta cycle.

Comment 9

[Nathan Froyd [:froydnj]]

Given that this has been triaged as P3, and the dependent bugs would be complicated to uplift, marking fix-optional for 54 and 55.

Comment 10

[:Paolo Amadini]

Grover, can you verify that this is fixed by bug 1009116?

Comment 11

[u554753]

Verified on Windows, Mac, and Ubuntu as of today's Nightly.