1312161 - Intermittent toolkit/components/extensions/test/mochitest/test_ext_contentscript_about_blank.html | Test timed out.

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=5504505&repo=autoland

https://queue.taskcluster.net/v1/task/QXifiekbQHmHyNSJhZU9xw/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: bug 1312161 - Ensure cleanup when match_about_blank test fails,

Review commit: https://reviewboard.mozilla.org/r/87806/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87806/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8803622 [details]
bug 1312161 - Ensure cleanup when match_about_blank test fails,

https://reviewboard.mozilla.org/r/87806/#review86800

Thanks for looking into this. However, I don't think this is going to fix the problem. `awaitMessage` queues unexpected messages, so it can actually be safely called even after the message has been received. And looking into the logs for the failures, there aren't any "script ran" messages for these scripts.

This is only happening on Android, so perhaps there's some Android-specific optimization that's preventing us from handling these iframes correctly some of the time?

Comment 3

[Tomislav Jovanovic :zombie]

Comment on attachment 8803622 [details]
bug 1312161 - Ensure cleanup when match_about_blank test fails,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87806/diff/1-2/

Comment 4

[Tomislav Jovanovic :zombie]

> And looking into the logs for the failures, there aren't any "script ran"
> messages for these scripts.

doh!


> This is only happening on Android, so perhaps there's some Android-specific
> optimization that's preventing us from handling these iframes correctly some
> of the time?

I know little about android optimizations.  This is causing fallout test failures (bug 1272890 comment 18), so as a temp measure, we can try cleaning up better on failures.

Or if it's too frequent, maybe we should disable it on android.

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8803622 [details]
bug 1312161 - Ensure cleanup when match_about_blank test fails,

https://reviewboard.mozilla.org/r/87806/#review86804

This has already been backed out, so there's no need for a separate patch. Let's just disable the test on Android and re-land the original patch, and then file a follow-up bug to fix it on Android.

::: toolkit/components/extensions/test/mochitest/test_ext_contentscript_about_blank.html:74
(Diff revision 2)
> +    if (win && !win.closed) {
> +      win.close();
> +    }

This isn't really necessary. Cascading failures are expected after timeouts.

::: toolkit/components/extensions/test/mochitest/test_ext_contentscript_about_blank.html:77
(Diff revision 2)
> +  let win;
> +  SimpleTest.registerCleanupFunction(() => {
> +    if (win && !win.closed) {
> +      win.close();
> +    }
> +    return extension.unload();

This happens automatically.

Comment 6

[Intermittent Failures Robot]

11 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 6
* mozilla-inbound: 5

Platform breakdown:
* android-4-3-armv7-api15: 10
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1312161&startday=2016-10-17&endday=2016-10-23&tree=all

Comment 7

[Intermittent Failures Robot]

9 failures in 820 pushes (0.011 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 6
* mozilla-inbound: 3

Platform breakdown:
* android-4-3-armv7-api15: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1312161&startday=2017-05-29&endday=2017-06-04&tree=all