Closed
Bug 1312167
Opened 7 years ago
Closed 7 years ago
Remove _overrideValue field from urlbar-rich-result-popup binding
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox52 | --- | affected |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
1.06 KB,
patch
|
Details | Diff | Splinter Review |
Having overrideValue store the actual value in _overrideValue seems like an entirely unnecessary complication. Am I missing something? Btw, it's not obvious what this overrides, why, when etc.. Would be nice if this was documented.
Attachment #8803597 -
Flags: review?(mak77)
Comment 1•7 years ago
|
||
it's part of the autocomplete xpidl, it's a real property
Comment 2•7 years ago
|
||
it's overriding this http://searchfox.org/mozilla-central/rev/84075be5067b68dc6cb3b89f999645650e68c05b/toolkit/content/widgets/autocomplete.xml#919
Comment 3•7 years ago
|
||
the reason it uses _overrideValue is that overrideValue is readonly, but I need to set it from the input code in urlbarBindings
Assignee | ||
Comment 4•7 years ago
|
||
Ah, okay. I suppose a <field> can't override a parent binding's <property>? In this case this has to stay as-is.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Assignee | ||
Updated•7 years ago
|
Attachment #8803597 -
Flags: review?(mak77)
Comment 5•7 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4) > Ah, okay. I suppose a <field> can't override a parent binding's <property>? > In this case this has to stay as-is. right, and it's documented in the idl itself, that's why I didn't add further details there.
You need to log in
before you can comment on or make changes to this bug.
Description
•