1312167 - Remove _overrideValue field from urlbar-rich-result-popup binding

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Dão Gottwald [::dao]]

Attachment: patch

Having overrideValue store the actual value in _overrideValue seems like an entirely unnecessary complication. Am I missing something?

Btw, it's not obvious what this overrides, why, when etc.. Would be nice if this was documented.

Comment 1

[Marco Bonardo [:mak]]

it's part of the autocomplete xpidl, it's a real property

Comment 2

[Marco Bonardo [:mak]]

it's overriding this

http://searchfox.org/mozilla-central/rev/84075be5067b68dc6cb3b89f999645650e68c05b/toolkit/content/widgets/autocomplete.xml#919

Comment 3

[Marco Bonardo [:mak]]

the reason it uses _overrideValue is that overrideValue is readonly, but I need to set it from the input code in urlbarBindings

Comment 4

[Dão Gottwald [::dao]]

Ah, okay. I suppose a <field> can't override a parent binding's <property>? In this case this has to stay as-is.

Comment 5

[Marco Bonardo [:mak]]

(In reply to Dão Gottwald [:dao] from comment #4)
> Ah, okay. I suppose a <field> can't override a parent binding's <property>?
> In this case this has to stay as-is.

right, and it's documented in the idl itself, that's why I didn't add further details there.