1312295 - Change ReflowInputFlags to use uint32_t

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Mats Palmgren (inactive)]

Bug 1300369 and bug 1269046 will add flags to this struct so we need
more than 16 bits.  We might as well change the type to uint32_t now.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Change ReflowInputFlags to use uint32_t since we'll need more than 16 bits here

(re-ordering mFlags / mReflowDepth to avoid alignment spill)

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8803726 [details] [diff] [review]
Change ReflowInputFlags to use uint32_t since we'll need more than 16 bits here

Review of attachment 8803726 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99a23306822
Change ReflowInputFlags to use uint32_t since we'll need more than 16 bits here.  r=dholbert

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a99a23306822

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Why couldn't these flags just use bool? I see no value to have them using a fixed length integer type.

Comment 6

[Daniel Holbert [:dholbert]]

(That makes sense to me. I think they might be uint-bitfield-typed for historical reasons which predate our ability to use 'bool', perhaps?)

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I remember some of us had discussion of using bool vs integer type in bug 1294628.

Comment 8

[Mats Palmgren (inactive)]

Making them bool:1 sounds fine to me.