1312321 - StateObject::SetState should be passed by value

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/84075be5067b68dc6cb3b89f999645650e68c05b/dom/media/MediaDecoderStateMachine.cpp#254

|aArgs| might reference data members which might be modified by Exit(). Using pass-by-value will save this horror and need no death grip.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1312321. Part 1 - make StateObject::SetState pass-by-value.

Review commit: https://reviewboard.mozilla.org/r/87944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87944/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1312321. Part 2 - make SetState() protected again.

Review commit: https://reviewboard.mozilla.org/r/87946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87946/

Comment 3

[James Cheng[:JamesCheng]]

Comment on attachment 8803791 [details]
Bug 1312321. Part 2 - make SetState() protected again.

https://reviewboard.mozilla.org/r/87946/#review87000

Comment 4

[James Cheng[:JamesCheng]]

Comment on attachment 8803790 [details]
Bug 1312321. Part 1 - make StateObject::SetState pass-by-value.

https://reviewboard.mozilla.org/r/87944/#review86994

LGTM

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7fb1a72dd5c
Part 1 - make StateObject::SetState pass-by-value. r=JamesCheng
https://hg.mozilla.org/integration/autoland/rev/bf7df2a398a4
Part 2 - make SetState() protected again. r=JamesCheng

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b7fb1a72dd5c
https://hg.mozilla.org/mozilla-central/rev/bf7df2a398a4