Closed
Bug 1312333
Opened 8 years ago
Closed 8 years ago
Include bug1309191 in devtools l10n migration script
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
|
7.85 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
Bug 1309191 just landed renaming a bunch of strings migrated in bug 1308500 https://hg.mozilla.org/mozilla-central/diff/41978ce40aaa/devtools/client/locales/en-US/netmonitor.properties I think it makes sense to cover them in the same migration. Also fixing a couple of broken localization notes.
|
Assignee | |
Comment 1•8 years ago
|
||
@Pike Do you feel like reviewing this patch, since Julian is on PTO? 1) All keys are renamed from netmonitor.footer.filter* to netmonitor.footer.filter.* with the remaining part lowercase 2) I dropped netmonitor.footer.filterFreetext.key because it was changed in bug 1268444 (from 'F' to 'CmdOrCtrl+F'), no point in migrating it. 3) The newline at the end is irrelevant, the script ignores lines without '=' 4) The .clear l10n note was wrong in the DTD file, and there's not much we can do about it, besides fixing the .properties one.
Attachment #8803774 -
Flags: review?(l10n)
|
||
Updated•8 years ago
|
Attachment #8803774 -
Flags: review?(l10n) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bcbed6279d1a Include bug1309191 in devtools l10n migration script for NetMonitor. r=pike
Keywords: checkin-needed
Priority: -- → P1
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bcbed6279d1a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•