Hide the section of Offline Web Content and User Data in about:preferences

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Preferences
VERIFIED FIXED
10 months ago
4 months ago

People

(Reporter: Fischer, Assigned: Fischer)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [storage-v1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
Remove the section of Offline Web Content and User Data under Network of Advanced of about:preferences because the management of app cache is going to integrate into the new Storage management section.
(Assignee)

Updated

10 months ago
Component: Device Permissions → Preferences
No longer depends on: 1312348
(Assignee)

Updated

10 months ago
Blocks: 1312351
No longer blocks: 1309118
(Assignee)

Updated

10 months ago
Blocks: 1312361
(Assignee)

Updated

10 months ago
No longer blocks: 1312361
(Assignee)

Updated

10 months ago
Depends on: 1313003
(Assignee)

Updated

10 months ago
Depends on: 1313602
(Assignee)

Updated

10 months ago
No longer depends on: 1313602
Comment hidden (mozreview-request)
(Assignee)

Comment 2

5 months ago
Comment on attachment 8848997 [details]
Bug 1312349 - Hide the section of Offline Web Content and User Data in about:preferences

Hi Jaws,

This patch is to hide the Offline web content section in about:preferences because the new Storage management handles appcache as well.

Thanks.
Attachment #8848997 - Flags: review?(jaws)
(Assignee)

Comment 3

5 months ago
(In reply to Fischer [:Fischer] from comment #2)
> Comment on attachment 8848997 [details]
> Bug 1312349 - Remove the section of Offline Web Content and User Data in
> about:preferences
> 
> Hi Jaws,
> 
> This patch is to hide the Offline web content section in about:preferences
> because the new Storage management handles appcache as well.
> 
> Thanks.
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcb620599eff2a833f912ea9aa3fdb209b9de425
(Assignee)

Updated

5 months ago
Blocks: 1348733
(Assignee)

Updated

5 months ago
No longer blocks: 1348733
Assignee: nobody → fliu
Status: NEW → ASSIGNED

Comment 4

5 months ago
mozreview-review
Comment on attachment 8848997 [details]
Bug 1312349 - Hide the section of Offline Web Content and User Data in about:preferences

https://reviewboard.mozilla.org/r/121836/#review124468

::: browser/components/preferences/in-content/advanced.js:99
(Diff revision 1)
>      setEventListener("viewSecurityDevicesButton", "command",
>                       gAdvancedPane.showSecurityDevices);
>      setEventListener("cacheSize", "change",
>                       gAdvancedPane.updateCacheSizePref);
>  
> +    if (Services.prefs.getBoolPref("browser.aboutPref.offlineGroup.enabled")) {

So what happens if this pref is disabled? Shouldn't we keep the other code path around until we are sure this will ship?

::: modules/libpref/init/all.js:5632
(Diff revision 1)
>  // To enable the DOM implementation, turn on "dom.storageManager.enabled"
>  pref("browser.storageManager.enabled", false);
>  pref("browser.storageManager.pressureNotification.minIntervalMS", 1200000);
>  pref("browser.storageManager.pressureNotification.usageThresholdGB", 5);
> +// Once the Storage Management is completed.
> +// The Offline(Appcache) Group section in about:oreferences will be hidden.

about:preferences, not about:oreferences
Attachment #8848997 - Flags: review?(jaws) → review-
(In reply to Fischer [:Fischer] from comment #0)
> Remove the section of Offline Web Content and User Data under Network of
> Advanced of about:preferences because the management of app cache is going
> to integrate into the new Storage management section.

Has the work for "management of app cache and the new Storage management section" finished? I see the "Offline Web Content and User Data" section on Firefox 52 Beta. Should that section not be there on Beta or Release?
Flags: needinfo?(fliu)
(Assignee)

Comment 6

5 months ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> (In reply to Fischer [:Fischer] from comment #0)
> > Remove the section of Offline Web Content and User Data under Network of
> > Advanced of about:preferences because the management of app cache is going
> > to integrate into the new Storage management section.
> 
> Has the work for "management of app cache and the new Storage management
> section" finished? I see the "Offline Web Content and User Data" section on
> Firefox 52 Beta. Should that section not be there on Beta or Release?
Yes, will enable the pref to have it still display there.
Flags: needinfo?(fliu)
Summary: Remove the section of Offline Web Content and User Data in about:preferences → Hide the section of Offline Web Content and User Data in about:preferences
Comment hidden (mozreview-request)

Comment 8

5 months ago
mozreview-review
Comment on attachment 8848997 [details]
Bug 1312349 - Hide the section of Offline Web Content and User Data in about:preferences

https://reviewboard.mozilla.org/r/121836/#review125514

::: modules/libpref/init/all.js:5634
(Diff revision 2)
>  pref("browser.storageManager.pressureNotification.minIntervalMS", 1200000);
>  pref("browser.storageManager.pressureNotification.usageThresholdGB", 5);
> +// Once the Storage Management is completed.
> +// The Offline(Appcache) Group section in about:preferences will be hidden.
> +// And the task to clear appcache will be done by Storage Management.
> +pref("browser.aboutPref.offlineGroup.enabled", true);

Sorry I didn't notice this before.

Since this preference is specifically related to about:preferences we shouldn't have it in all.js. It should instead be in firefox.js.

Also, please rename this pref to:
browser.preferences.offlineGroup.enabled

And place this preference near the other browser.preferences.* prefs in firefox.js.
Attachment #8848997 - Flags: review?(jaws) → review-
(Assignee)

Comment 9

5 months ago
mozreview-review-reply
Comment on attachment 8848997 [details]
Bug 1312349 - Hide the section of Offline Web Content and User Data in about:preferences

https://reviewboard.mozilla.org/r/121836/#review125514

> Sorry I didn't notice this before.
> 
> Since this preference is specifically related to about:preferences we shouldn't have it in all.js. It should instead be in firefox.js.
> 
> Also, please rename this pref to:
> browser.preferences.offlineGroup.enabled
> 
> And place this preference near the other browser.preferences.* prefs in firefox.js.

Thanks for reminding this. Moved the browser.preferences.offlineGroup.enabled pref to the firefox.js.
Comment hidden (mozreview-request)

Comment 11

5 months ago
mozreview-review
Comment on attachment 8848997 [details]
Bug 1312349 - Hide the section of Offline Web Content and User Data in about:preferences

https://reviewboard.mozilla.org/r/121836/#review125986

Overall this looks good. I would have granted r+ on this, but since bug 1343682 you will need to make the changes to browser/components/preferences/in-content and browser/components/preferences/in-content-old/. Sorry :(
Attachment #8848997 - Flags: review?(jaws) → review-
(Assignee)

Comment 12

5 months ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #11)
> Comment on attachment 8848997 [details]
> Bug 1312349 - Hide the section of Offline Web Content and User Data in
> about:preferences
> 
> https://reviewboard.mozilla.org/r/121836/#review125986
> 
> Overall this looks good. I would have granted r+ on this, but since bug
> 1343682 you will need to make the changes to
> browser/components/preferences/in-content and
> browser/components/preferences/in-content-old/. Sorry :(
That's ok :) Will update based on the new changes from bug 1343682.
Comment hidden (mozreview-request)
(Assignee)

Comment 14

5 months ago
(In reply to Fischer [:Fischer] from comment #13)
> Comment on attachment 8848997 [details]
> Bug 1312349 - Hide the section of Offline Web Content and User Data in
> about:preferences
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/121836/diff/3-4/
Hi Jaws,
The same changes have been made to the in-content-old preferences as well.

Comment 15

5 months ago
mozreview-review
Comment on attachment 8848997 [details]
Bug 1312349 - Hide the section of Offline Web Content and User Data in about:preferences

https://reviewboard.mozilla.org/r/121836/#review126418
Attachment #8848997 - Flags: review?(jaws) → review+
This will need to be rebased now that bug 1335907 has landed.
(Assignee)

Comment 17

5 months ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #16)
> This will need to be rebased now that bug 1335907 has landed.
Seems the bug 1335907 has not yet landed and no conflict with the central codebase so would like to continue check-in.
TRY with browser.preferences.offlineGroup.enabled as FALSE: https://treeherder.mozilla.org/#/jobs?repo=try&revision=afb17cb06014c690b4fd2addd392a1cd630b41ea
TRY with browser.preferences.offlineGroup.enabled as TRUE : https://treeherder.mozilla.org/#/jobs?repo=try&revision=a41100692dd0e3c2ec94b1b8fdf339b9ccb4248f
Keywords: checkin-needed

Comment 18

5 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12e1d4360901
Hide the section of Offline Web Content and User Data in about:preferences r=jaws
Keywords: checkin-needed

Comment 19

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/12e1d4360901
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 20

4 months ago
I have reproduced this issue with Nightly 52.0a1 (2016-10-24) on Windows 10, 64 bit!

The fix is now verified on Latest Nightly 55.0a1

Build ID 	20170412030252
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170412]
Thanks!
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.