Closed
Bug 1312352
Opened 8 years ago
Closed 8 years ago
Netmonitor: the "Timeline" column shoud have a text label when the request list is empty
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox52 verified)
Tracking | Status | |
---|---|---|
firefox52 | --- | verified |
People
(Reporter: jsnajdr, Assigned: gasolin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [netmonitor])
Attachments
(2 files, 1 obsolete file)
STR: 1. Open Netmonitor to its "initial" state where no requests were made yet. 2. Look at the "Timeline" column - the rightmost one Expected: It has a "Timeline" label. After first request is made, this label is converted to a timing marker axis. Actual: There is no "Timeline" label - the column header is completely empty. This is a regression from bug 1308500 - the "label.requests-menu-waterfall-label" element should have a "value" attribute, but it has "label" instead: http://searchfox.org/mozilla-central/rev/84075be5067b68dc6cb3b89f999645650e68c05b/devtools/client/netmonitor/netmonitor.xul#251
Updated•8 years ago
|
Blocks: netmonitor-html
Flags: qe-verify?
Updated•8 years ago
|
Flags: qe-verify? → qe-verify+
Priority: -- → P2
QA Contact: ciprian.georgiu
Whiteboard: [netmonitor][triage] → [netmonitor]
Assignee | ||
Comment 1•8 years ago
|
||
The label element should have `content=` instead of `label=` attribute
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: --- → 52.3 - Nov 7
Priority: P2 → P1
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•8 years ago
|
||
referred to https://github.com/mozilla/gecko-dev/blob/master/devtools/client/inspector/inspector.xhtml#L117 Steps: 1. open a new tab 2. open developer > network from menu The timeline label is shown before hit the 'reload' button
Reporter | ||
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8804958 [details] Bug 1312352 - Netmonitor: the Timeline column shoud have a text label when the request list is empty; https://reviewboard.mozilla.org/r/88776/#review88824 ::: devtools/client/netmonitor/netmonitor.xul:155 (Diff revision 1) > flex="1"> > <image id="requests-menu-waterfall-image"/> > <box id="requests-menu-waterfall-label-wrapper"> > <label id="requests-menu-waterfall-label" > class="plain requests-menu-waterfall" > - data-localization="label=netmonitor.toolbar.waterfall"/> > + data-localization="content=netmonitor.toolbar.waterfall"/> There are two ways how to specify the text for a "label" element - either in the textContent, or in the "value" attribute. If you use textContent, the label text has wrong vertical alignment. See the screenshot you made and attached to the bug - it's clearly visible there. Using a "value" attribute is the correct way.
Attachment #8804958 -
Flags: review?(jsnajdr) → review-
Assignee | ||
Comment 5•8 years ago
|
||
changed to `value=` then text valign works normally
Attachment #8804965 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Reporter | ||
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8804958 [details] Bug 1312352 - Netmonitor: the Timeline column shoud have a text label when the request list is empty; https://reviewboard.mozilla.org/r/88776/#review90294
Attachment #8804958 -
Flags: review?(jsnajdr) → review+
Pushed by jsnajdr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0d2d67e61236 Netmonitor: the Timeline column shoud have a text label when the request list is empty;r=jsnajdr
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0d2d67e61236
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 11•8 years ago
|
||
I was able to reproduce this issue on an old Nightly build 52.0a1 (Build ID 20161024030205). This bug is verified fixed on latest Nightly 52.0a1 from 2016-11-08 across platforms: - Windows 10 x64 - Mac OS X 10.11 - Ubuntu 14.04 x86 LTS I will mark here accordingly.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•