1312352 - Netmonitor: the "Timeline" column shoud have a text label when the request list is empty

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Jarda Snajdr [:jsnajdr]]

STR:
1. Open Netmonitor to its "initial" state where no requests were made yet.
2. Look at the "Timeline" column - the rightmost one

Expected:
It has a "Timeline" label. After first request is made, this label is converted to a timing marker axis.

Actual:
There is no "Timeline" label - the column header is completely empty.

This is a regression from bug 1308500 - the "label.requests-menu-waterfall-label" element should have a "value" attribute, but it has "label" instead:

http://searchfox.org/mozilla-central/rev/84075be5067b68dc6cb3b89f999645650e68c05b/devtools/client/netmonitor/netmonitor.xul#251

Comment 1

[[e-mail]]

The label element should have `content=` instead of `label=` attribute

Comment 2

[[e-mail]]

Attachment: Bug 1312352 - Netmonitor: the Timeline column shoud have a text label when the request list is empty;

Review commit: https://reviewboard.mozilla.org/r/88776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88776/

Comment 3

[[e-mail]]

Attachment: timeline label

referred to https://github.com/mozilla/gecko-dev/blob/master/devtools/client/inspector/inspector.xhtml#L117

Steps:

1. open a new tab
2. open developer > network from menu

The timeline label is shown before hit the 'reload' button

Comment 4

[Jarda Snajdr [:jsnajdr]]

Comment on attachment 8804958 [details]
Bug 1312352 - Netmonitor: the Timeline column shoud have a text label when the request list is empty;

https://reviewboard.mozilla.org/r/88776/#review88824

::: devtools/client/netmonitor/netmonitor.xul:155
(Diff revision 1)
>                          flex="1">
>                    <image id="requests-menu-waterfall-image"/>
>                    <box id="requests-menu-waterfall-label-wrapper">
>                      <label id="requests-menu-waterfall-label"
>                             class="plain requests-menu-waterfall"
> -                           data-localization="label=netmonitor.toolbar.waterfall"/>
> +                           data-localization="content=netmonitor.toolbar.waterfall"/>

There are two ways how to specify the text for a "label" element - either in the textContent, or in the "value" attribute.

If you use textContent, the label text has wrong vertical alignment. See the screenshot you made and attached to the bug - it's clearly visible there.

Using a "value" attribute is the correct way.

Comment 5

[[e-mail]]

Attachment: timeline label

changed to `value=` then text valign works normally

Comment 6

[[e-mail]]

Comment on attachment 8804958 [details]
Bug 1312352 - Netmonitor: the Timeline column shoud have a text label when the request list is empty;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88776/diff/1-2/

Comment 7

[Jarda Snajdr [:jsnajdr]]

Comment on attachment 8804958 [details]
Bug 1312352 - Netmonitor: the Timeline column shoud have a text label when the request list is empty;

https://reviewboard.mozilla.org/r/88776/#review90294

Comment 8

[[e-mail]]

thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d2d67e61236
Netmonitor: the Timeline column shoud have a text label when the request list is empty;r=jsnajdr

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0d2d67e61236

Comment 11

[Ciprian Georgiu, Desktop QA]

I was able to reproduce this issue on an old Nightly build 52.0a1 (Build ID 20161024030205).

This bug is verified fixed on latest Nightly 52.0a1 from 2016-11-08 across platforms:
- Windows 10 x64
- Mac OS X 10.11
- Ubuntu 14.04 x86 LTS
I will mark here accordingly.