131237 - Don't assert at nsStandardURL::SetUserPass during normal HTTP publishing

Status: RESOLVED WORKSFORME

(Core :: Networking, defect)

Description

[Charles Manske]

Use Composer to publish to an HTTP server. Be sure to fill in correct username
and password.
During nsWebBrowserPersist::CloneNodeWithFixedUpURIAttributes() code path, the 
password is nulled out as part of normal processing and triggering an assert that 
is rather annoying!

Comment 1

[Kathleen :Brade]

note: the assertion I see is when calling SetUserPass with a file url (which
doesn't have a host).

Comment 2

[Charles Manske]

brade: no, this one is different. They are both annoying!

Comment 3

[Charles Manske]

Today I don't see any asserts! I am seeing a problem in that even when I supply
both username and password, I'm getting the nsIAuth::promptUsernameAndPassword
dialog, so the code path may be different.

Comment 4

[Kathleen :Brade]

*** Bug 133980 has been marked as a duplicate of this bug. ***

Comment 5

[Darin Fisher]

mass futuring of untargeted bugs

Comment 6

[Kathleen :Brade]

*** Bug 186715 has been marked as a duplicate of this bug. ***

Comment 7

[kinmoz]

I'd love to see this assert go away or turned into a warning ... anything that 
doesn't throw up a dialog everytime it gets hit in a debug win32 build. :-) I
have this assert commented out in every debug build I have just so I can use my
builds for dogfood and save files.

Comment 8

[Darin Fisher]

Attachment: patch

yeah, no need for this assertion if the caller is only clearing the userpass. 
this patch moves it down.

Comment 9

[kinmoz]

Comment on attachment 111018 [details] [diff] [review]
patch

sr=[e-mail]

THANK YOU!!!

Comment 10

[Darin Fisher]

-> default owner

Comment 11

[Patrick McManus [:mcmanus]]

this code has been updated similarly via some other bug