Closed Bug 1312384 Opened 8 years ago Closed 8 years ago

Add 0xCA to U+05BA mapping to windows-1255

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: emk, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

to reflect a recent change to the Encoding Standard.
Blocks: encoding
Steps to generate new mapping files for windows-1255: 1. Compile intl/uconv/tools/umaptable.c (You can compile this file without using the Mozilla build system at all.) 2. Download <http://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP1255.TXT>. 3. Edit CP1255.TXT to add the 0xCA=>U+05BA mapping. 4. $ umaptable -uf < CP1255.TXT > cp1255.uf 5. $ umaptable -ut < CP1255.TXT > cp1255.ut 6. On Windows, you will have to convert line endings of generated files.
Comment on attachment 8804517 [details] Bug 1312384 - Update windows-1255 converter to reflect a change to the Encoding Standard. https://reviewboard.mozilla.org/r/88432/#review87580 r=me. Out of interest, can you give a link to where this change to the Encoding Standard was announced and/or discussed?
Attachment #8804517 - Flags: review?(smontagu) → review+
(In reply to Masatoshi Kimura [:emk] from comment #3) > Steps to generate new mapping files for windows-1255: > 1. Compile intl/uconv/tools/umaptable.c (You can compile this file without > using the Mozilla build system at all.) > 2. Download > <http://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP1255.TXT>. > 3. Edit CP1255.TXT to add the 0xCA=>U+05BA mapping. For future changes it might make more sense to use https://encoding.spec.whatwg.org/index-*.txt and not have to edit the mapping files. I assume that at most this would require trivial changes to umaptable.c
(In reply to Simon Montagu :smontagu from comment #4) > r=me. Out of interest, can you give a link to where this change to the > Encoding Standard was announced and/or discussed? Please see the "See Also:" field. It has a link to the GitHub issue. (In reply to Simon Montagu :smontagu from comment #5) > For future changes it might make more sense to use > https://encoding.spec.whatwg.org/index-*.txt and not have to edit the > mapping files. I assume that at most this would require trivial changes to > umaptable.c I wish bug 1261841 obsoleted umaptable...
Attachment #8804516 - Flags: review?(Ms2ger) → review?(annevk)
Comment on attachment 8804516 [details] Bug 1312384 - Update Web Platform Tests to reflect a change to the Encoding Standard. Thanks emk!
Attachment #8804516 - Flags: review?(annevk) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/6963f5ab0000 Update Web Platform Tests to reflect a change to the Encoding Standard. r=annevk https://hg.mozilla.org/integration/mozilla-inbound/rev/49861f351092 Update windows-1255 converter to reflect a change to the Encoding Standard. r=smontagu
Anne, please set the review flag from ReviewBoard next time. MozReview does not recognize the review flag that was set from Bugzilla directly. So I had to push the commits manually.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: