1312384 - Add 0xCA to U+05BA mapping to windows-1255

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Masatoshi Kimura [:emk]]

to reflect a recent change to the Encoding Standard.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1312384 - Update Web Platform Tests to reflect a change to the Encoding Standard.

Review commit: https://reviewboard.mozilla.org/r/88430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88430/

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1312384 - Update windows-1255 converter to reflect a change to the Encoding Standard.

Review commit: https://reviewboard.mozilla.org/r/88432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88432/

Comment 3

[Masatoshi Kimura [:emk]]

Steps to generate new mapping files for windows-1255:
1. Compile intl/uconv/tools/umaptable.c (You can compile this file without using the Mozilla build system at all.)
2. Download <http://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP1255.TXT>.
3. Edit CP1255.TXT to add the 0xCA=>U+05BA mapping.
4. $ umaptable -uf < CP1255.TXT > cp1255.uf
5. $ umaptable -ut < CP1255.TXT > cp1255.ut
6. On Windows, you will have to convert line endings of generated files.

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 8804517 [details]
Bug 1312384 - Update windows-1255 converter to reflect a change to the Encoding Standard.

https://reviewboard.mozilla.org/r/88432/#review87580

r=me. Out of interest, can you give a link to where this change to the Encoding Standard was announced and/or discussed?

Comment 5

[Simon Montagu :smontagu]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> Steps to generate new mapping files for windows-1255:
> 1. Compile intl/uconv/tools/umaptable.c (You can compile this file without
> using the Mozilla build system at all.)
> 2. Download
> <http://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP1255.TXT>.
> 3. Edit CP1255.TXT to add the 0xCA=>U+05BA mapping.

For future changes it might make more sense to use https://encoding.spec.whatwg.org/index-*.txt and not have to edit the mapping files. I assume that at most this would require trivial changes to umaptable.c

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to Simon Montagu :smontagu from comment #4)
> r=me. Out of interest, can you give a link to where this change to the
> Encoding Standard was announced and/or discussed?

Please see the "See Also:" field. It has a link to the GitHub issue.

(In reply to Simon Montagu :smontagu from comment #5)
> For future changes it might make more sense to use
> https://encoding.spec.whatwg.org/index-*.txt and not have to edit the
> mapping files. I assume that at most this would require trivial changes to
> umaptable.c

I wish bug 1261841 obsoleted umaptable...

Comment 7

[Anne (:annevk)]

Comment on attachment 8804516 [details]
Bug 1312384 - Update Web Platform Tests to reflect a change to the Encoding Standard.

Thanks emk!

Comment 8

[Anne (:annevk)]

Simon, the change was discussed at https://github.com/whatwg/encoding/issues/73 and resulted in https://github.com/whatwg/encoding/commit/e32a57b886bdb7514f385da3805e606e6faed54f.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6963f5ab0000
Update Web Platform Tests to reflect a change to the Encoding Standard. r=annevk
https://hg.mozilla.org/integration/mozilla-inbound/rev/49861f351092
Update windows-1255 converter to reflect a change to the Encoding Standard. r=smontagu

Comment 10

[Masatoshi Kimura [:emk]]

Anne, please set the review flag from ReviewBoard next time.
MozReview does not recognize the review flag that was set from Bugzilla directly. So I had to push the commits manually.

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6963f5ab0000
https://hg.mozilla.org/mozilla-central/rev/49861f351092