1312413 - `mDefaultDevice` should be an index in `mDeviceIndexes`

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Paul Adenot (:padenot)]

http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTC.h#240

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1312413 - `mDefaultDevice` should be an index in `mDeviceIndexes`.

Review commit: https://reviewboard.mozilla.org/r/88106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88106/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8803898 [details]
Bug 1312413 - `mDefaultDevice` should be an index in `mDeviceIndexes`.

https://reviewboard.mozilla.org/r/88106/#review87030

Thanks!

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Please nominate for aurora before uplift

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2b9b6e2da6b
`mDefaultDevice` should be an index in `mDeviceIndexes`. r=jesup

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2b9b6e2da6b

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8803898 [details]
Bug 1312413 - `mDefaultDevice` should be an index in `mDeviceIndexes`.

NOTE: will require the trivial follow-on fix in bug 1307754

Approval Request Comment
[Feature/regressing bug #]: full-duplex landing (spring)

[User impact if declined]: Incorrect default audio mic when preferred mic changes
(It so happens that on the first time through, 'i' is the same as 'j' should be, so it's ok by chance, but if the device list changes later it can be wrong)

[Describe test coverage new/current, TreeHerder]: Requires manual plug/unplug testing

[Risks and why]: virtually none; at worst wrong mic selected

[String/UUID change made/needed]: none

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8803898 [details]
Bug 1312413 - `mDefaultDevice` should be an index in `mDeviceIndexes`.

Fix an issue related to related to WebRTC. Beta51+. Should be in 51 beta 2.

Comment 8

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-beta/rev/f68cadfae212