1312421 - Renaming of the aurora version in the app launcher

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1306732 +++

I think we should indeed rename "Aurora" to "Firefox aurora". We did that in the product but not on the android launcher.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Looking at the app manifest the name of the launcher icon should be controlled by MOZ_APP_DISPLAYNAME:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/branding/aurora/configure.sh#5

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1312421 - Rename of the aurora version in the app launcher

Review commit: https://reviewboard.mozilla.org/r/88074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88074/

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Yes, I found it in between :)

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8803875 [details]
Bug 1312421 - Rename of the aurora version in the app launcher

https://reviewboard.mozilla.org/r/88074/#review86992

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5eb1ff9a3490
Rename of the aurora version in the app launcher r=sebastian

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5eb1ff9a3490

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Do we want to uplift this?

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8803875 [details]
Bug 1312421 - Rename of the aurora version in the app launcher

Approval Request Comment
[Feature/regressing bug #]: #1306732 was doing only half of the job
[User impact if declined]: People will see "Aurora" instead of "Firefox aurora"
[Describe test coverage new/current, TreeHerder]: We already have "Firefox beta" for the beta channel. We should be safe.
[Risks and why]: Same as the other bug: We don't know what we don't know. Some internal code could rely on this but I am not expecting that. The text might be too long in some contexts, we will figure out.
[String/UUID change made/needed]: None, this is not translated!

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8803875 [details]
Bug 1312421 - Rename of the aurora version in the app launcher

Rename aurora version. Take it in 51 aurora.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/16783504ea99

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Works great