Closed
Bug 1312494
Opened 8 years ago
Closed 8 years ago
Mobile Bookmarks left pane query points at wrong bookmark id
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: tcsc, Assigned: lina)
Details
Attachments
(1 file)
The result of this is having no items under "Mobile Bookmarks" in the places organizer. I have "place:folder=335" as the query url. My mobile bookmarks root is at 742, and it seems like my old mobile bookmarks "root" (before bug 1302901 landed) was at 335. (Assigning to kit per request in irc)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8803978 [details] Bug 1312494 - Fix up queries that point to the wrong folder in `_ensureMobileQuery`. https://reviewboard.mozilla.org/r/88166/#review87112 ::: toolkit/components/places/Database.cpp (Diff revision 2) > // Delete the old folder. > rv = DeleteBookmarkItem(folderIds[i]); > if (NS_FAILED(rv)) return rv; > } > > - // Delete any left pane queries that point to the old folder. We'll From discussion in IRC, now that we leave these around, I'd feel a little better about this if you made it so the validator reported an error if we end up syncing these items up to the server for some reason. Simply adding `ignored = true` for them in createClientRecordsFromTree should be enough to make them show up as `serverUnexpected`.
Attachment #8803978 -
Flags: review?(tchiovoloni)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8803978 [details] Bug 1312494 - Fix up queries that point to the wrong folder in `_ensureMobileQuery`. https://reviewboard.mozilla.org/r/88166/#review87118 Looks good to me.
Attachment #8803978 -
Flags: review?(tchiovoloni) → review+
Comment hidden (mozreview-request) |
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11758049a838 Fix up queries that point to the wrong folder in `_ensureMobileQuery`. r=tcsc
Updated•8 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/11758049a838
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in
before you can comment on or make changes to this bug.
Description
•