Open Bug 1312699 Opened 5 years ago Updated 4 years ago

Make TelemetryController.testReset()/reset() behave correctly

Categories

(Toolkit :: Telemetry, defect, P3)

defect
Points:
2

Tracking

()

Tracking Status
firefox52 --- wontfix

People

(Reporter: Dexter, Unassigned)

Details

(Whiteboard: [measurement:client])

Right now, we do something that looks odd in racy in in the code [1] that we use to reset Telemetry between XPCSHELL tests.

Ideally, we should change that this way:

1) Call the shutdown() function of all our subsystems (TelemetryEnvironment, TelemetrySession, ...)
2) Reset any state/variable held by these modules. We change change the testReset function of other modules to do that.
3) Then call the setup() functions again for each subsystem.

This could potentially cause some fallout in our tests if they were relying on the old, unclear behaviour to work.

[1] - https://dxr.mozilla.org/mozilla-central/rev/c845bfd0accb7e0c29b41713255963b08006e701/toolkit/components/telemetry/TelemetryController.jsm#947
Points: --- → 2
Priority: -- → P3
Whiteboard: [measurement:client]
Mass wontfix for bugs affecting firefox 52.
You need to log in before you can comment on or make changes to this bug.