1312699 - Make TelemetryController.testReset()/reset() behave correctly

Status: NEW

(Toolkit :: Telemetry, defect, P3)

Description

[Alessio Placitelli [:Dexter]]

Right now, we do something that looks odd in racy in in the code [1] that we use to reset Telemetry between XPCSHELL tests.

Ideally, we should change that this way:

1) Call the shutdown() function of all our subsystems (TelemetryEnvironment, TelemetrySession, ...)
2) Reset any state/variable held by these modules. We change change the testReset function of other modules to do that.
3) Then call the setup() functions again for each subsystem.

This could potentially cause some fallout in our tests if they were relying on the old, unclear behaviour to work.

[1] - https://dxr.mozilla.org/mozilla-central/rev/c845bfd0accb7e0c29b41713255963b08006e701/toolkit/components/telemetry/TelemetryController.jsm#947

Comment 1

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.