|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Created attachment 8804220 [details] settings-logout.png After selecting "disconnect" on the account settings page and returning to settings the avatar from the account is still visible (See screenshot). The next time I open settings the default avatar is shown again.
Comment on attachment 8807978 [details] Bug 1312719 - Clear icon by setIcon with null drawable before setIcon with resId, https://reviewboard.mozilla.org/r/90898/#review90876 ::: mobile/android/base/java/org/mozilla/gecko/preferences/SyncPreference.java:58 (Diff revision 1) > + // Bug 1312719 - IconDrawable is prior to IconResId, drawable must be set null before setIcon(resId) > + // http://androidxref.com/5.1.1_r6/xref/frameworks/base/core/java/android/preference/Preference.java#102 > + setIcon(null); > setIcon(R.drawable.sync_avatar_default); This is weird - but it works. Do you know why? Doesn't setIcon(int) call setIcon(Drawable)?
Because in bindView, iconRes will take effect only when iconDrawable is null. Maybe I should update the link to following line? http://androidxref.com/5.1.1_r6/xref/frameworks/base/core/java/android/preference/Preference.java#562
(In reply to Max Liu [:maliu] from comment #3) > Because in bindView, iconRes will take effect only when iconDrawable is null. > > Maybe I should update the link to following line? > http://androidxref.com/5.1.1_r6/xref/frameworks/base/core/java/android/ > preference/Preference.java#562 Yeah, and/or add a comment mentioning that the new icon resource will only be loaded if no icon is set. As this patch is already reviewed: Just add the 'checkin-needed' keyword to the bug and a sheriff will land the patch. :)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a14ca8dbcc4b Clear icon by setIcon with null drawable before setIcon with resId, r=sebastian