1312724 - Broken Visual Bookmarks add-on

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: addon-2.30.2-fx.xpi

[Affected versions]:
Firefox 52.0a1 (2016-10-24)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.11.6

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Install the attached add-on:
3.Open a new tab.


[Expected Results]:
Visual Bookmarks favorite sites are successfully displayed while opening a new tab.( http://screencast.com/t/7iyp74eu )


[Actual Results]:
The classical new tab page is opened.( http://screencast.com/t/MSc8F0jTRZq )


[Regression Range]:
Last good revision: 9eab2642989dee91264d169ba613a86a488b02ab
First bad revision: a9a143d2179a352652b970b99d062214d1bf9bd8
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9eab2642989dee91264d169ba613a86a488b02ab&tochange=a9a143d2179a352652b970b99d062214d1bf9bd8


Looks like the following bug has the changes which introduced the regression: Bug 1309350

Comment 1

[Kris Maglione [:kmag]]

This is a bug in the extension:

lib/utils/logger/index.js:18:const appConfig = require('../../../../config');

has an extra ../

I'm not sure how it ever worked in the first place, though...

Comment 2

[Andy McKay]

Also line 9:

const appDirs = require('../../modules/common/dirs');

I changed both those lines and it worked just fine. I'll contact the add-on author to let them know.

Comment 3

[Kris Maglione [:kmag]]

So. The reason this previously worked, in case anyone else is interested:

"lib/utils/logger/index.js" + "../../../../config" is pre-resolved to
"../config".

The old loader first tries to load this as "resource://config.js" and fails.

Then it tries, in order:

- lib/utils/logger/node_modules/../config.js
- lib/utils/node_modules/../config.js
- lib/node_modules/../config.js

The last one is the same as 'lib/config.js', so it works.

The new loader code refuses to resolve "resource://vb-at-yandex-dot-ru/" +
"../config.js" to "resource://config.js" (as it should), so it throws before
it gets to the (invalid) node_modules resolution step.

Comment 4

[Andy McKay]

Contacted authors: https://addons.mozilla.org/en-US/firefox/addon/yandex-visual-bookmarks/

Comment 5

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Addon breakage

Comment 6

[Danil Ivanov]

Thank you! We will upload new version after replace deprecated jQuery version inside.

Comment 7

[Marcia Knous [:marcia]]

Tracking 52- as this appears to be resolved by the add on author making a code adjustment.

Comment 8

[Kris Maglione [:kmag]]

Danil, can you please let us know when this is fixed?

Thanks

Comment 9

[Gerry Chang [:gchang]]

Un-track for 51 as this will be fixed by add-on author.

Comment 10

[Marcia Knous [:marcia]]

Tracking 50- - as noted in Comment 9, this is gated on the addon author.

Comment 11

[Andy McKay]

Version 2.30.3 which fixes this is currently in the AMO review queue.

Comment 12

[Vasilica Tamas, QA [:vtamas]]

Performed a bit of exploratory testing around this new version - 2.30.3 - and it seems to work as expected across all versions (Firefox 52.0a1 (2016-11-02), Firefox 51.0a2 (2016-11-02), Firefox 50.0 RC, Firefox 49.0.2) under Windows 10 64-bit and Ubuntu 12.04 64-bit.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Untracked and based on the latest testing by SV, 50 may be unaffected.

Comment 14

[Danil Ivanov]

2.30.5 (like 2.30.3) is available in the AMO.
Thank you.